1701321 - Intermittent browser/components/urlbar/tests/browser/browser_quicksuggest.js | Test timed out -

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: nerli [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=334587678&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/YJCdJcjrTpe4ZHm9aivxKw/runs/0/artifacts/public/logs/live_backing.log

---

[task 2021-03-26T19:16:34.284Z] 19:16:34     INFO - TEST-START | browser/components/urlbar/tests/browser/browser_quicksuggest.js
[task 2021-03-26T19:18:04.329Z] 19:18:04     INFO - TEST-INFO | started process screentopng
[task 2021-03-26T19:18:05.036Z] 19:18:05     INFO - TEST-INFO | screentopng: exit 0
[task 2021-03-26T19:18:05.037Z] 19:18:05     INFO - Buffered messages logged at 19:16:34
[task 2021-03-26T19:18:05.038Z] 19:18:05     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_quicksuggest.js | Sanity check the temporary file doesn't exist. - true == true - 
[task 2021-03-26T19:18:05.038Z] 19:18:05     INFO - Entering test bound init
[task 2021-03-26T19:18:05.039Z] 19:18:05     INFO - Buffered messages finished
[task 2021-03-26T19:18:05.040Z] 19:18:05     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_quicksuggest.js | Test timed out - 
[task 2021-03-26T19:18:05.041Z] 19:18:05     INFO - GECKO(1553) | MEMORY STAT | vsize 20975802MB | residentFast 1640MB
[task 2021-03-26T19:18:05.042Z] 19:18:05     INFO - TEST-OK | browser/components/urlbar/tests/browser/browser_quicksuggest.js | took 90061ms
[task 2021-03-26T19:18:05.044Z] 19:18:05     INFO - checking window state```

Comment 1

[Intermittent Failures Robot]

3 failures in 3967 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 3

Platform and build breakdown:

• linux1804-64-asan: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1701321&startday=2021-03-22&endday=2021-03-28&tree=all

Comment 2

[Andrei Oprea [:andreio]]

I can't reproduce this locally on osx or linux with --verify. Going to wait an see if the numbers go up.

Comment 3

[Intermittent Failures Robot]

27 failures in 3125 pushes (0.009 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 27

Platform and build breakdown:

• linux1804-64-asan: 26
  • opt: 26
• linux1804-64: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1701321&startday=2021-03-29&endday=2021-04-04&tree=all

Comment 4

[Natalia Csoregi [:nataliaCs]]

Update:

There have been 33 failures within the last 7 days and a total of 63 failures since the bug has been created, all of them on Linux 18.04 x64 asan opt.

Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=336026776&repo=autoland&lineNumber=2707

[task 2021-04-09T22:28:01.244Z] 22:28:01 INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_quicksuggest.js | Sanity check the temporary file doesn't exist. - true == true -
[task 2021-04-09T22:28:01.244Z] 22:28:01 INFO - Entering test bound init
[task 2021-04-09T22:28:01.244Z] 22:28:01 INFO - Buffered messages finished
[task 2021-04-09T22:28:01.244Z] 22:28:01 INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_quicksuggest.js | Test timed out -
[task 2021-04-09T22:28:01.244Z] 22:28:01 INFO - GECKO(1541) | MEMORY STAT | vsize 20975756MB | residentFast 1632MB
[task 2021-04-09T22:28:01.245Z] 22:28:01 INFO - TEST-OK | browser/components/urlbar/tests/browser/browser_quicksuggest.js | took 90057ms

Andrei, could you check if any action has to be taken from your side given the failure rate?
Thank you.

Comment 5

[Intermittent Failures Robot]

33 failures in 3854 pushes (0.009 failures/push) were associated with this bug in the last 7 days.

This is the #48 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 33

Platform and build breakdown:

• linux1804-64-asan: 32
  • opt: 32
• linux1804-64-tsan: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1701321&startday=2021-04-05&endday=2021-04-11&tree=all

Comment 6

[Andrei Oprea [:andreio]]

Attachment: Bug 1701321 - Skip browser_quicksuggest.js for intermittent timeouts on asan builds

Comment 7

[Andrei Oprea [:andreio]]

Keep open to investigate problem, possibly slow machine + asan build is hitting the timeout threshold for urlbar tests.

the test is probably crossing the urlbar timeouts due to additional overhead. There is a timeout in the urlbar, if we go over it the urlbar just gives up waiting for results and returns control to the user
maybe we need a relaxTimeouts() API for slow tests

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/830173689b0f
Skip browser_quicksuggest.js for intermittent timeouts on asan builds r=mak

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/830173689b0f

Comment 10

[Drew Willcoxon :adw]

(In reply to Andrei Oprea [:andreio] from comment #7)

maybe we need a relaxTimeouts() API for slow tests

requestLongerTimeout?

Comment 11

[Intermittent Failures Robot]

7 failures in 4255 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 7

Platform and build breakdown:

• linux1804-64-asan: 7
  • opt: 7

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1701321&startday=2021-04-12&endday=2021-04-18&tree=all

Comment 12

[Intermittent Failures Robot]

12 failures in 3224 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 12

Platform and build breakdown:

• macosx1014-64-qr: 4
  • opt: 2
  • debug: 2
• windows10-64: 2
  • debug: 1
  • opt: 1
• windows10-64-qr: 1
  • opt: 1
• windows7-32: 1
  • opt: 1
• linux1804-64: 2
  • debug: 1
  • opt: 1
• linux1804-64-qr: 2
  • debug: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1701321&startday=2021-04-19&endday=2021-04-25&tree=all

Comment 13

[Intermittent Failures Robot]

14 failures in 3706 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 14

Platform and build breakdown:

• linux1804-64-qr: 2
  • opt: 1
  • debug: 1
• linux1804-64: 2
  • opt: 1
  • debug: 1
• macosx1014-64-qr: 4
  • opt: 2
  • debug: 2
• windows10-64-qr: 2
  • opt: 1
  • debug: 1
• windows10-64: 2
  • opt: 1
  • debug: 1
• windows7-32: 2
  • debug: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1701321&startday=2021-04-26&endday=2021-05-02&tree=all

Comment 14

[Intermittent Failures Robot]

1 failures in 3279 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• linux1804-64-asan: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1701321&startday=2021-05-03&endday=2021-05-09&tree=all

Comment 15

[Drew Willcoxon :adw]

Taking this -- we've made changes to how quick suggest is initialized and the tests, and I think we can stop skipping them on ASAN now. This try is green after many retriggers: https://treeherder.mozilla.org/jobs?repo=try&revision=cf2755ee9c6c1c253b0b315311ef62e53ca68f32

Comment 16

[Drew Willcoxon :adw]

Attachment: Bug 1701321 - Re-enable some browser quick suggest tests on ASAN.

We've made changes to how quick suggest is initialized and the tests, and I
think we can stop skipping them on ASAN now. This try is green after many
retriggers:
https://treeherder.mozilla.org/jobs?repo=try&revision=cf2755ee9c6c1c253b0b315311ef62e53ca68f32

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ecc17529126c
Re-enable some browser quick suggest tests on ASAN. r=daisuke

Comment 18

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ecc17529126c