1701347 - Menulist chrome tests are unhappy with proton enabled

Status: RESOLVED FIXED

(Firefox :: Theme, task)

Description

[:Gijs (he/him)]

Mike kindly offered to look into this.

Comment 1

[:Gijs (he/him)]

Trypush failure reference: https://treeherder.mozilla.org/jobs?repo=try&revision=3ed214b2325b5bf83933eaae85ee85ffb66fc768&selectedTaskRun=HYU1KtDpT52ZqEj4gvuW_g.0

With stuff like TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_menulist_position.xhtml | Labels horizontally aligned for index 0

Comment 2

[Mike Conley (:mconley) (:⚙️)]

This blocks enabling Proton by default in Nightly, otherwise we're gonna get backed out by test failures, so suggesting a P1.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

I can easily reproduce this locally. Investigating...

Comment 4

[:Gijs (he/him)]

Different menulist-related tests fail on Windows, it would seem: https://treeherder.mozilla.org/jobs?repo=try&revision=92877c982eb7b424d383c371e4061a1c54dc8bb9&selectedTaskRun=QNrnigXUQ5e5SZQChV_M2Q.0 .

Edit: and perhaps worth noting that this doesn't include the context menu changes so the display of the menulist popup itself on Windows should be the same as before.

Comment 5

[:Gijs (he/him)]

Err, please disregard that last comment, it looks like that is related to proton context menus, I was looking at the wrong trypush...

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Yeah, the failures in test_menulist_position.xhtml seem to be related to the vertical centering of the menulist popups on macOS. Looking for an acceptable solution.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

The test is unhappy because it's trying to test that the menupopup on macOS has the current item selection centered over top of the menulist itself. This is a native behaviour that will eventually go away once bug 1699532 is fixed, although this doesn't currently block MR1.

In the meantime, we'll make the test use the old-school "native"-style menulist so that it passes.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1701347 - Use a native menulist in test_menulist_position.xhtml. r?Gijs!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ca109977007
Use a native menulist in test_menulist_position.xhtml. r=Gijs

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5ca109977007