Closed Bug 1701412 Opened 3 years ago Closed 3 years ago

Very frequent browser_test_selection_urlbar.js | autofilled value as expected - "a" == "addons.mozilla.org/" - JS frame :: /accessible/tests/browser/events/browser_test_selection when Gecko 89 merges to Beta on 2021-04-19

Categories

(Core :: Disability Access APIs, defect)

Product:
Core
Component:
Disability Access APIs
Version:
Firefox 89
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox86 --- unaffected
firefox87 --- unaffected
firefox88 --- unaffected
firefox89 + verified

People

(Reporter: malexandru, Assigned: morgan)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1701412: Use bookmark instead of visit for autofill r?eeejay
48 bytes, text/x-phabricator-request
Details | Review

Failure log, raw log.
Central-as-beta simulation, how to run these simulations.

[task 2021-03-27T13:35:39.868Z] 13:35:39     INFO - TEST-OK | accessible/tests/browser/events/browser_test_scrolling.js | took 790ms
[task 2021-03-27T13:35:39.887Z] 13:35:39     INFO - checking window state
[task 2021-03-27T13:35:39.892Z] 13:35:39     INFO - TEST-START | accessible/tests/browser/events/browser_test_selection_urlbar.js
[task 2021-03-27T13:35:40.712Z] 13:35:40     INFO - TEST-INFO | started process screenshot
[task 2021-03-27T13:35:40.812Z] 13:35:40     INFO - TEST-INFO | screenshot: exit 0
[task 2021-03-27T13:35:40.812Z] 13:35:40     INFO - Buffered messages logged at 13:35:39
[task 2021-03-27T13:35:40.812Z] 13:35:40     INFO - Entering test bound 
[task 2021-03-27T13:35:40.812Z] 13:35:40     INFO - TEST-PASS | accessible/tests/browser/events/browser_test_selection_urlbar.js | Recieved document load complete event - 
[task 2021-03-27T13:35:40.812Z] 13:35:40     INFO - Buffered messages logged at 13:35:40
[task 2021-03-27T13:35:40.812Z] 13:35:40     INFO - TEST-PASS | accessible/tests/browser/events/browser_test_selection_urlbar.js | Actually remote browser - 
[task 2021-03-27T13:35:40.813Z] 13:35:40     INFO - Creating new window
[task 2021-03-27T13:35:40.813Z] 13:35:40     INFO - TEST-PASS | accessible/tests/browser/events/browser_test_selection_urlbar.js | Recieved focus event - 
[task 2021-03-27T13:35:40.814Z] 13:35:40     INFO - Focusing window
[task 2021-03-27T13:35:40.814Z] 13:35:40     INFO - Autofilling after typing `a` in new window URL bar.
[task 2021-03-27T13:35:40.814Z] 13:35:40     INFO - TEST-PASS | accessible/tests/browser/events/browser_test_selection_urlbar.js | Recieved text caret moved event - 
[task 2021-03-27T13:35:40.815Z] 13:35:40     INFO - Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“i” modifiers=“accel,alt,shift” id=“key_browserToolbox”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 1280}]
[task 2021-03-27T13:35:40.815Z] 13:35:40     INFO - Buffered messages finished
[task 2021-03-27T13:35:40.815Z] 13:35:40     INFO - TEST-UNEXPECTED-FAIL | accessible/tests/browser/events/browser_test_selection_urlbar.js | autofilled value as expected - "a" == "addons.mozilla.org/" - JS frame :: chrome://mochitests/content/browser/accessible/tests/browser/events/browser_test_selection_urlbar.js :: runTests :: line 48
[task 2021-03-27T13:35:40.815Z] 13:35:40     INFO - Stack trace:
[task 2021-03-27T13:35:40.815Z] 13:35:40     INFO - chrome://mochitests/content/browser/accessible/tests/browser/events/browser_test_selection_urlbar.js:runTests:48
[task 2021-03-27T13:35:40.815Z] 13:35:40     INFO - Ensuring caret moved on text selection
[task 2021-03-27T13:35:40.815Z] 13:35:40     INFO - Leaving test bound 
[task 2021-03-27T13:35:40.915Z] 13:35:40     INFO - GECKO(3400) | MEMORY STAT | vsize 2104181MB | vsizeMaxContiguous 65169751MB | residentFast 277MB | heapAllocated 121MB
[task 2021-03-27T13:35:40.915Z] 13:35:40     INFO - TEST-OK | accessible/tests/browser/events/browser_test_selection_urlbar.js | took 1018ms
[task 2021-03-27T13:35:40.920Z] 13:35:40     INFO - checking window state
[task 2021-03-27T13:35:40.941Z] 13:35:40     INFO - TEST-START | accessible/tests/browser/events/browser_test_textcaret.js
[task 2021-03-27T13:35:41.653Z] 13:35:41     INFO - GECKO(3400) | MEMORY STAT | vsize 2104191MB | vsizeMaxContiguous 65169751MB | residentFast 288MB | heapAllocated 129MB
[task 2021-03-27T13:35:41.653Z] 13:35:41     INFO - TEST-OK | accessible/tests/browser/events/browser_test_textcaret.js | took 714ms
[task 2021-03-27T13:35:41.672Z] 13:35:41     INFO - checking window state
[task 2021-03-27T13:35:42.470Z] 13:35:42     INFO - GECKO(3400) | [Parent 7588, IPC I/O Parent] WARNING: file /builds/worker/checkouts/gecko/ipc/chromium/src/base/process_util_win.cc:167
[task 2021-03-27T13:35:43.138Z] 13:35:43     INFO - GECKO(3400) | Completed ShutdownLeaks collections in process 4404
[task 2021-03-27T13:35:43.156Z] 13:35:43     INFO - GECKO(3400) | Completed ShutdownLeaks collections in process 10028
[task 2021-03-27T13:35:43.158Z] 13:35:43     INFO - GECKO(3400) | Completed ShutdownLeaks collections in process 10044
[task 2021-03-27T13:35:43.158Z] 13:35:43     INFO - GECKO(3400) | Completed ShutdownLeaks collections in process 1460
[task 2021-03-27T13:35:43.168Z] 13:35:43     INFO - GECKO(3400) | Completed ShutdownLeaks collections in process 10064
[task 2021-03-27T13:35:43.735Z] 13:35:43     INFO - GECKO(3400) | Completed ShutdownLeaks collections in process 7588
[task 2021-03-27T13:35:43.735Z] 13:35:43     INFO - TEST-START | Shutdown

This failure has increased in frequency since the previous central-as-beta simulation, central retriggers are intermittent so this looks to be a beta only issue.

:adw, do you have any idea why this might be failing on beta? I don't even know where to start looking.

While this is an a11y test, the a11y bits aren't the cause of the failure. The test basically does this:

  // ... Open a new window ...
  await PlacesTestUtils.addVisits("http://addons.mozilla.org");
  // ... Focus the address bar, escape twice to ensure any existing address is selected ...
  EventUtils.synthesizeKey("a", {}, newWin);
  await UrlbarTestUtils.promiseSearchComplete(newWin);
  Assert.equal(
    newWin.gURLBar.inputField.value,
    "addons.mozilla.org/",
    "autofilled value as expected"
  );

So, we type "a" and expect it to autofill addons.mozilla.org (as added in history), but it doesn't in beta for some reason.

Flags: needinfo?(adw)

This only fails on Windows x64 shippable (= optimized) with WebRender enabled.

It probably has to do with the fact that Nightly ships with a bookmark for https://addons.mozilla.org/en-US/firefox/addon/nightly-tester-tools/ but Beta doesn't. Long story short, if the test adds a bookmark instead of a visit for addons.mozilla.org, then it's guaranteed to autofill, so that's probably what you want.

Autofill involves a frecency threshold that's based on the mean frecency of all the URLs in your Places database -- if a domain doesn't clear the threshold, then it won't be autofilled. Usually in new profiles it's not enough to visit a URL only once for its domain to start autofilling. There's an escape hatch for bookmarks though: Domains of bookmarked URLs will always be autofilled.

I'm guessing that the test works on Nightly because the URL happens to be bookmarked on Nightly. The fact that it adds a visit to addons.mozilla.org is incidental. :-) So one other way to fix it would be to add more visits, maybe 3-5? Bookmarking it is better though.

Flags: needinfo?(adw)
Assignee: nobody → mreschenberg

I can fix this 😀

Pushed by mreschenberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fc68f9ca86aa
Use bookmark instead of visit for autofill r=eeejay
Regressions: 1702684

https://hg.mozilla.org/mozilla-central/rev/fc68f9ca86aa

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox89: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: