1701416 - Remove unneeded code from forked DOMI

Status: RESOLVED FIXED

(SeaMonkey :: General, task)

Description

[Ian Neal]

Now we have forked the DOMI code for SeaMonkey 2.53 we can remove the code that is not needed for SeaMonkey. This includes:

• Unused locales
• Overlays for other applications
• Support for older Gecko code
• Unused files

Comment 1

[Ian Neal]

Attachment: 1701446-domi-tidy-2538.patch

Tested against 2.53.8pre

Comment 2

[Frank-Rainer Grahl (:frg)]

The patch removes locales we ship in 2.53 like fi and zh-TW. Is this intended?

Patch name has a typo but comment is correct.

Comment 3

[Ian Neal]

(In reply to Frank-Rainer Grahl (:frg) from comment #2)

The patch removes locales we ship in 2.53 like fi and zh-TW. Is this intended?

Patch name has a typo but comment is correct.

If you look at the code starting at:
https://hg.mozilla.org/dom-inspector/file/tip/resources/Makefile.in#l14

You will see that for DOMi we only ship de, el, en-GB, en-US, pl, ru, sk and sv-SE
The locales I am removing are all incomplete to varying levels and not currently exposed to Pontoon to be completed.

We could keep those unshipped locales that we do localise SeaMonkey for just in case we decide to change how DOMi is packaged for the 2.53.x releases so that those missing strings are available on Pontoon.

Yes, bug number is incorrect in the name of the patch, oops.

Comment 4

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9212002 [details] [diff] [review]
1701446-domi-tidy-2538.patch

LGTM Would like to change the version to reflect the changes.

r/a+ with the added version change.

Comment 5

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/26cf030b81c79768add25819e99203d2805f9f66
Remove unneeded code from forked DOMI. r=frg a=frg