Open Bug 1701416 Opened 2 months ago Updated 8 days ago

Remove unneeded code from forked DOMI

Categories

(SeaMonkey :: General, task)

SeaMonkey 2.53 Branch

Tracking

(seamonkey2.53? affected, seamonkey2.57esr unaffected)

ASSIGNED
Tracking Status
seamonkey2.53 ? affected
seamonkey2.57esr --- unaffected

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

(Depends on 1 open bug)

Details

(Whiteboard: SM2.53.8)

Attachments

(1 file)

Now we have forked the DOMI code for SeaMonkey 2.53 we can remove the code that is not needed for SeaMonkey. This includes:

  • Unused locales
  • Overlays for other applications
  • Support for older Gecko code
  • Unused files
Summary: Remove non-SeaMonkey code from forked DOMI → Remove unneeded code from forked DOMI

Tested against 2.53.8pre

Attachment #9212002 - Flags: review?(frgrahl)
Attachment #9212002 - Flags: approval-comm-release?

The patch removes locales we ship in 2.53 like fi and zh-TW. Is this intended?

Patch name has a typo but comment is correct.

Flags: needinfo?(iann_bugzilla)

(In reply to Frank-Rainer Grahl (:frg) from comment #2)

The patch removes locales we ship in 2.53 like fi and zh-TW. Is this intended?

Patch name has a typo but comment is correct.

If you look at the code starting at:
https://hg.mozilla.org/dom-inspector/file/tip/resources/Makefile.in#l14

You will see that for DOMi we only ship de, el, en-GB, en-US, pl, ru, sk and sv-SE
The locales I am removing are all incomplete to varying levels and not currently exposed to Pontoon to be completed.

We could keep those unshipped locales that we do localise SeaMonkey for just in case we decide to change how DOMi is packaged for the 2.53.x releases so that those missing strings are available on Pontoon.

Yes, bug number is incorrect in the name of the patch, oops.

Flags: needinfo?(iann_bugzilla)
Version: Trunk → SeaMonkey 2.53 Branch

Comment on attachment 9212002 [details] [diff] [review]
1701446-domi-tidy-2538.patch

LGTM Would like to change the version to reflect the changes.

r/a+ with the added version change.

Attachment #9212002 - Flags: review?(frgrahl)
Attachment #9212002 - Flags: review+
Attachment #9212002 - Flags: approval-comm-release?
Attachment #9212002 - Flags: approval-comm-release+
You need to log in before you can comment on or make changes to this bug.