1701418 - Compilation error with rust 1.51.0: "panic message is not a string literal"

Status: RESOLVED FIXED

(Testing :: Mozbase Rust, task)

Description

[Kartikaya Gupta (email:[e-mail])]

STR: rustup update stable && mach build

Compilation fails with:

 0:58.45 error: panic message is not a string literal
 0:58.45    --> testing/mozbase/rust/mozprofile/src/prefreader.rs:258:33
 0:58.46     |
 0:58.46 258 |                     x => panic!(format!("Boolean wasn't 'true' or 'false' (was {})", x)),
 0:58.46     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 0:58.46     |
 0:58.46     = note: `-D non-fmt-panic` implied by `-D warnings`
 0:58.46     = note: this is no longer accepted in Rust 2021
 0:58.46     = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Apparently panic! can take format arguments directly now.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=693c9d3fd7de034e03b48fb82aa18d69283e5b30

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Also https://treeherder.mozilla.org/jobs?repo=try&revision=d94295c1ed028c851b654e485fc6a4ba04898781 for a similar fix in wrench code

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1701418 - Make panic call compatible with rustc 1.51.0. r?glandium

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1701418 - Make wrench assert calls compatible with rustc 1.51.0. r?kvark

Depends on D110029

Comment 5

[Mike Hommey [:glandium]]

Why didn't I hit this when I tried the upgrade to 1.51.0 on try? https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=b94XHQpmTBOzrQ7l3tbCaQ.0&revision=061bad52b004739ab1432ef0ca7594af5ca37dfc

Comment 6

[Kartikaya Gupta (email:[e-mail])]

It looks like the relevant code is in the rust version of mozprofile, which AFAICT is only included by geckodriver and that in turn is only enabled under certain conditions which seem to exclude in automation?

Comment 7

[Kartikaya Gupta (email:[e-mail])]

I also added a couple of wrench jobs to your try push and they failed as I would expect (this is fixed by the second patch on this bug). wrench doesn't get compiled except when running specific jobs that use it.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #6)

It looks like the relevant code is in the rust version of mozprofile, which AFAICT is only included by geckodriver and that in turn is only enabled under certain conditions which seem to exclude in automation?

The geckodriver build jobs are toolchain jobs and run separate from the build ones. You can find them in Treeherder as gd. Note that I'm going to add a new geckodriver preset for try via bug 1700454 so that it makes it easier to include all relevant jobs.

Comment 9

[Daniel Holbert [:dholbert]]

I'm going to go ahead and trigger lando for part 1 here, to reduce potential for dupes cropping up while we're waiting for part 2.

(This morning I independently noticed & filed & posted a patch for the "part 1" warning, over in bug 1701700.)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d88e4618dd97
Make panic call compatible with rustc 1.51.0. r=webdriver-reviewers,jgraham

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Feel free to also r+/lando on part 2, it's pretty trivial

Comment 13

[Daniel Holbert [:dholbert]]

I tagged nical as an alternate reviewer on phabricator; hopefully he or kvark can r+ and trigger lando soonish.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c06a6fd2c86
Make wrench assert calls compatible with rustc 1.51.0. r=kvark

Comment 15

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/d88e4618dd97
https://hg.mozilla.org/mozilla-central/rev/3c06a6fd2c86