1701423 - Intermittent devtools/client/storage/test/browser_storage_fission_cookies.js | Table row has an entry for: lorem2 with value: ipsum2 - Got undefined, expected "ipsum2"

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: malexandru [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=334654861&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/WpSP2Y4pSV-_kp3XeD31Vg/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/WpSP2Y4pSV-_kp3XeD31Vg/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

[task 2021-03-27T17:14:37.610Z] 17:14:37     INFO - TEST-START | devtools/client/storage/test/browser_storage_fission_cookies.js
[task 2021-03-27T17:14:46.814Z] 17:14:46     INFO - TEST-INFO | started process screencapture
[task 2021-03-27T17:14:46.885Z] 17:14:46     INFO - TEST-INFO | screencapture: exit 0
[task 2021-03-27T17:14:46.885Z] 17:14:46     INFO - Buffered messages logged at 17:14:37
[task 2021-03-27T17:14:46.885Z] 17:14:46     INFO - Entering test bound 
[task 2021-03-27T17:14:46.893Z] 17:14:46     INFO - Adding a new tab with URL: http://example.com/document-builder.sjs?html=%3Ch1%3EMain%3C/h1%3E%3Cscript%3Edocument.cookie=%22foo=bar%22;%3C/script%3E%3Ciframe%20src=%22http://example.net/document-builder.sjs?html=%253Ch1%253Eiframe%253C/h1%253E%253Cscript%253Edocument.cookie%2520=%2520%2522lorem=ipsum%2522;%253C/script%253E%22%3E
[task 2021-03-27T17:14:46.893Z] 17:14:46     INFO - Buffered messages logged at 17:14:39
[task 2021-03-27T17:14:46.893Z] 17:14:46     INFO - Console message: [JavaScript Warning: "Cookie “foo” will be soon rejected because it has the “SameSite” attribute set to “None” or an invalid value, without the “secure” attribute. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite" {file: "http://example.com/document-builder.sjs?html=%3Ch1%3EMain%3C/h1%3E%3Cscript%3Edocument.cookie=%22foo=bar%22;%3C/script%3E%3Ciframe%20src=%22http://example.net/document-builder.sjs?html=%253Ch1%253Eiframe%253C/h1%253E%253Cscript%253Edocument.cookie%2520=%2520%2522lorem=ipsum%2522;%253C/script%253E%22%3E" line: 1}]
[task 2021-03-27T17:14:46.893Z] 17:14:46     INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.com/document-builder.sjs?html=%3Ch1%3EMain%3C/h1%3E%3Cscript%3Edocument.cookie=%22foo=bar%22;%3C/script%3E%3Ciframe%20src=%22http://example.net/document-builder.sjs?html=%253Ch1%253Eiframe%253C/h1%253E%253Cscript%253Edocument.cookie%2520=%2520%2522lorem=ipsum%2522;%253C/script%253E%22%3E" line: 0}]
[task 2021-03-27T17:14:46.894Z] 17:14:46     INFO - Tab added and finished loading
[task 2021-03-27T17:14:46.894Z] 17:14:46     INFO - Console message: [JavaScript Warning: "Cookie “lorem” will be soon rejected because it has the “SameSite” attribute set to “None” or an invalid value, without the “secure” attribute. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite" {file: "http://example.net/document-builder.sjs?html=%3Ch1%3Eiframe%3C/h1%3E%3Cscript%3Edocument.cookie%20=%20%22lorem=ipsum%22;%3C/script%3E" line: 1}]
[task 2021-03-27T17:14:46.894Z] 17:14:46     INFO - Found a window: complete
[task 2021-03-27T17:14:46.894Z] 17:14:46     INFO - Found a window: complete
[task 2021-03-27T17:14:46.894Z] 17:14:46     INFO - Opening the storage inspector
[task 2021-03-27T17:14:46.895Z] 17:14:46     INFO - Opening the toolbox
[task 2021-03-27T17:14:46.895Z] 17:14:46     INFO - Buffered messages logged at 17:14:44
[task 2021-03-27T17:14:46.895Z] 17:14:46     INFO - Console message: QM_TRY failure (WARNING): 'Unavailable' at dom/cache/FileUtils.cpp:107 failed with result 0x80520008 (NS_ERROR_FILE_ALREADY_EXISTS)
[task 2021-03-27T17:14:46.895Z] 17:14:46     INFO - Console message: QM_TRY failure (WARNING): 'Unavailable' at dom/cache/FileUtils.cpp:107 failed with result 0x80520008 (NS_ERROR_FILE_ALREADY_EXISTS)
[task 2021-03-27T17:14:46.895Z] 17:14:46     INFO - Buffered messages logged at 17:14:46
[task 2021-03-27T17:14:46.896Z] 17:14:46     INFO - Making sure that the toolbox's frame is focused
[task 2021-03-27T17:14:46.896Z] 17:14:46     INFO - TEST-PASS | devtools/client/storage/test/browser_storage_fission_cookies.js | cookies > http://example.com is in the tree - 
[task 2021-03-27T17:14:46.896Z] 17:14:46     INFO - TEST-PASS | devtools/client/storage/test/browser_storage_fission_cookies.js | cookies > http://example.net is in the tree - 
[task 2021-03-27T17:14:46.896Z] 17:14:46     INFO - "cookies,http://example.com" is already selected, returning.
[task 2021-03-27T17:14:46.896Z] 17:14:46     INFO - TEST-PASS | devtools/client/storage/test/browser_storage_fission_cookies.js | Table row has an entry for: foo with value: bar - 
[task 2021-03-27T17:14:46.897Z] 17:14:46     INFO - Selecting "cookies,http://example.net".
[task 2021-03-27T17:14:46.897Z] 17:14:46     INFO - TEST-PASS | devtools/client/storage/test/browser_storage_fission_cookies.js | Table row has an entry for: lorem with value: ipsum - 
[task 2021-03-27T17:14:46.897Z] 17:14:46     INFO - Add more cookies
[task 2021-03-27T17:14:46.897Z] 17:14:46     INFO - Console message: [JavaScript Warning: "Cookie “foo2” will be soon rejected because it has the “SameSite” attribute set to “None” or an invalid value, without the “secure” attribute. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite" {file: "chrome://mochitests/content/browser/devtools/client/storage/test/browser_storage_fission_cookies.js" line: 40}]
[task 2021-03-27T17:14:46.897Z] 17:14:46     INFO - Console message: [JavaScript Warning: "Cookie “lorem2” will be soon rejected because it has the “SameSite” attribute set to “None” or an invalid value, without the “secure” attribute. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite" {file: "chrome://mochitests/content/browser/devtools/client/storage/test/browser_storage_fission_cookies.js" line: 44}]
[task 2021-03-27T17:14:46.897Z] 17:14:46     INFO - Selecting "cookies,http://example.com".
[task 2021-03-27T17:14:46.898Z] 17:14:46     INFO - TEST-PASS | devtools/client/storage/test/browser_storage_fission_cookies.js | Table row has an entry for: foo2 with value: bar2 - 
[task 2021-03-27T17:14:46.898Z] 17:14:46     INFO - Selecting "cookies,http://example.net".
[task 2021-03-27T17:14:46.898Z] 17:14:46     INFO - Buffered messages finished
[task 2021-03-27T17:14:46.898Z] 17:14:46     INFO - TEST-UNEXPECTED-FAIL | devtools/client/storage/test/browser_storage_fission_cookies.js | Table row has an entry for: lorem2 with value: ipsum2 - Got undefined, expected "ipsum2"
[task 2021-03-27T17:14:46.898Z] 17:14:46     INFO - Stack trace:
[task 2021-03-27T17:14:46.898Z] 17:14:46     INFO - chrome://mochikit/content/browser-test.js:test_is:1359
[task 2021-03-27T17:14:46.898Z] 17:14:46     INFO - chrome://mochitests/content/browser/devtools/client/storage/test/head.js:checkCookieData:1131
[task 2021-03-27T17:14:46.898Z] 17:14:46     INFO - chrome://mochitests/content/browser/devtools/client/storage/test/browser_storage_fission_cookies.js:null:49
[task 2021-03-27T17:14:46.898Z] 17:14:46     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1089
[task 2021-03-27T17:14:46.899Z] 17:14:46     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1129
[task 2021-03-27T17:14:46.899Z] 17:14:46     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:943
[task 2021-03-27T17:14:46.899Z] 17:14:46     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:1037
[task 2021-03-27T17:14:46.899Z] 17:14:46     INFO - Leaving test bound 
[task 2021-03-27T17:14:47.173Z] 17:14:47     INFO - Removing tab.
[task 2021-03-27T17:14:47.173Z] 17:14:47     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2021-03-27T17:14:47.195Z] 17:14:47     INFO - Got event: 'TabClose' on [object XULElement].
[task 2021-03-27T17:14:47.271Z] 17:14:47     INFO - Tab removed and finished closing
[task 2021-03-27T17:14:47.908Z] 17:14:47     INFO - TEST-PASS | devtools/client/storage/test/browser_storage_fission_cookies.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2021-03-27T17:14:47.992Z] 17:14:47     INFO - GECKO(1761) | MEMORY STAT | vsize 7639MB | residentFast 292MB | heapAllocated 101MB
[task 2021-03-27T17:14:47.993Z] 17:14:47     INFO - TEST-OK | devtools/client/storage/test/browser_storage_fission_cookies.js | took 10408ms
[task 2021-03-27T17:14:48.090Z] 17:14:48     INFO - checking window state
[task 2021-03-27T17:14:48.300Z] 17:14:48     INFO - TEST-START | devtools/client/storage/test/browser_storage_fission_cookies.js```

Comment 1

[Intermittent Failures Robot]

5 failures in 3967 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 5

Platform and build breakdown:

• linux1804-64-qr: 1
  • debug: 1
• linux1804-64: 1
  • debug: 1
• macosx1014-64-qr: 3
  • opt: 2
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1701423&startday=2021-03-22&endday=2021-03-28&tree=all

Comment 2

[Alexandru Michis [:malexandru]]

Started appearing on tier 1 jobs:
https://treeherder.mozilla.org/logviewer?job_id=334817282&repo=autoland&lineNumber=51032

Nicolas, could this be caused by the changes in Bug 1666529?

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Alexandru Michis [:malexandru] from comment #2)

Started appearing on tier 1 jobs:
https://treeherder.mozilla.org/logviewer?job_id=334817282&repo=autoland&lineNumber=51032

Nicolas, could this be caused by the changes in Bug 1666529?

it could be, I'm not sure. I can reproduce the issue locally but fairly infrequently, this is going to take a while to investigate :/

Comment 4

[Julian Descottes [:jdescottes]]

Note: there is a generic intermittent for those issues because we get the same failure in different similar tests: https://bugzilla.mozilla.org/show_bug.cgi?id=1673179

If you want the full picture about this issue, they are currently spread over 3 bugs:

• Bug 1701423 (this one, for cookies)
• Bug 1676319 (for session storage)
• Bug 1673179 (the generic one, but the recent failure is for local storage)

This seems to be a generic issue for all storage resources.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

I have a patch that seems to fix the intermittent: https://treeherder.mozilla.org/jobs?repo=try&revision=e700edeab44813dbf1ef6220cacc12f199c85b6f

I'm setting cookies for the top-level and the iframe in different tasks and waiting for the update event to be emitted.
The thing I'm wondering is if we have a race condition when getting multiple storage data updates somehow?

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1701423 - [devtools] Fix intermittent on browser_storage_fission_cookies.js. r=ochameau.

This patch waits for the "store-objects-edit" event to be emitted before checking
the content of the UI.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae1950c44d85
[devtools] Fix intermittent on browser_storage_fission_cookies.js. r=ochameau.

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ae1950c44d85

Comment 9

[Intermittent Failures Robot]

3 failures in 3125 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 3

Platform and build breakdown:

• macosx1014-64-qr: 2
  • debug: 2
• windows10-64: 1
  • asan: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1701423&startday=2021-03-29&endday=2021-04-04&tree=all