1701518 - [wpt-sync] Sync PR 28270 - Change ideographic space tests to use fixed `line-height`

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 28270 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28270
Details from upstream follow.

b'Koji Ishii <[e-mail]>' wrote:

Change ideographic space tests to use fixed line-height

It turned out that crbug.com/1193282 can affect the height of
lines that contains only U+3000 IDEOGRAPHIC SPACEs, because
the used fonts are not correct.

This patch applies fixed line-height to the tests so that
used fonts do not affect the layout.

Bug: 1193282
Change-Id: I73990d16f9d77879e9a007bb48c6c63491943400

Reviewed-on: https://chromium-review.googlesource.com/2789994
WPT-Export-Revision: 177ac3c1455b7d590cd9b1ac5d61ea87ca560530

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=46bc35e5e9c2ab4bb0da45657976e5f463f24cf7

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests

Status Summary

Firefox

PASS: 6

Chrome

FAIL: 6

Safari

FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3360a0bd5b2
[wpt PR 28270] - Change ideographic space tests to use fixed `line-height`, a=testonly
https://hg.mozilla.org/integration/autoland/rev/91d28ae16303
[wpt PR 28270] - Update wpt metadata, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef3f57f06597
[wpt PR 28270] - Change ideographic space tests to use fixed `line-height`, a=testonly
https://hg.mozilla.org/integration/autoland/rev/a3f3c9dd9d21
[wpt PR 28270] - Update wpt metadata, a=testonly

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7080a6e6553
[wpt PR 28270] - Change ideographic space tests to use fixed `line-height`, a=testonly
https://hg.mozilla.org/integration/autoland/rev/c55303e128dc
[wpt PR 28270] - Update wpt metadata, a=testonly

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26b5c9e1c766
[wpt PR 28270] - Change ideographic space tests to use fixed `line-height`, a=testonly
https://hg.mozilla.org/integration/autoland/rev/cffae38c975f
[wpt PR 28270] - Update wpt metadata, a=testonly

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/26b5c9e1c766
https://hg.mozilla.org/mozilla-central/rev/cffae38c975f