Closed Bug 1701524 Opened 3 years ago Closed 3 years ago

More markers could have inner window ids

Categories

(Core :: Gecko Profiler, task, P3)

task

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: florian, Assigned: florian)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

Opening this bug to attach a WIP patch I have.

Severity: -- → N/A
Priority: -- → P3
Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/59fd1d6e1ea4
add more inner window ids in markers, r=canaltinova.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

I think I might be getting a crash from this on try [1] when I push with --gecko-profile. My guess is that aAnimation->GetOwner() is returning nullptr when generating a profile marker [2]?

[1] https://treeherder.mozilla.org/logviewer?job_id=335748921&repo=try&lineNumber=2311

[2] https://searchfox.org/mozilla-central/source/dom/animation/AnimationEventDispatcher.h#65

Regressions: 1703717
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: