Closed
Bug 1701524
Opened 3 years ago
Closed 3 years ago
More markers could have inner window ids
Categories
(Core :: Gecko Profiler, task, P3)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
89 Branch
Tracking | Status | |
---|---|---|
firefox89 | --- | fixed |
People
(Reporter: florian, Assigned: florian)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
Opening this bug to attach a WIP patch I have.
Assignee | ||
Comment 1•3 years ago
|
||
Severity: -- → N/A
Priority: -- → P3
Pushed by fqueze@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/59fd1d6e1ea4 add more inner window ids in markers, r=canaltinova.
Comment 3•3 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox89:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Comment 4•3 years ago
•
|
||
I think I might be getting a crash from this on try [1] when I push with --gecko-profile
. My guess is that aAnimation->GetOwner()
is returning nullptr when generating a profile marker [2]?
[1] https://treeherder.mozilla.org/logviewer?job_id=335748921&repo=try&lineNumber=2311
[2] https://searchfox.org/mozilla-central/source/dom/animation/AnimationEventDispatcher.h#65
Depends on: 1728243
You need to log in
before you can comment on or make changes to this bug.
Description
•