1701587 - macOS Crash in [@ mozilla::wr::WebRenderAPI::SendTransaction]

Status: RESOLVED INVALID

(Core :: Graphics: WebRender, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

macOS crash new in Firefox 87, based on urls likely related to videos. crash-stats lists crashes for 13 installations so far.

Crash report: https://crash-stats.mozilla.org/report/index/a4c2bf76-0522-41cb-a140-4572a0210328

Reason: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS

Top 10 frames of crashing thread:

0 XUL mozilla::wr::WebRenderAPI::SendTransaction gfx/webrender_bindings/WebRenderAPI.cpp:452
1 XUL mozilla::layers::AsyncImagePipelineManager::ApplyAsyncImageForPipeline gfx/layers/wr/AsyncImagePipelineManager.cpp:501
2 XUL mozilla::layers::WebRenderBridgeParent::ProcessWebRenderParentCommands gfx/layers/wr/WebRenderBridgeParent.cpp:1461
3 XUL mozilla::layers::WebRenderBridgeParent::RecvSetDisplayList gfx/layers/wr/WebRenderBridgeParent.cpp:1212
4 libmozglue.dylib malloc memory/build/malloc_decls.h:51
5 XUL Pickle::EndRead const ipc/chromium/src/base/pickle.cc:460
6 XUL mozilla::layers::PWebRenderBridgeParent::OnMessageReceived ipc/ipdl/PWebRenderBridgeParent.cpp:403
7 libmozglue.dylib malloc memory/build/malloc_decls.h:51
8 XUL mozilla::layers::PCompositorManagerParent::OnMessageReceived ipc/ipdl/PCompositorManagerParent.cpp:205
9 libmozglue.dylib free memory/build/malloc_decls.h:54

Comment 1

[Brad Werth [:bradwerth]]

Adding to gfx-triage.

Comment 2

[Brad Werth [:bradwerth]]

Attachment: WIP: Bug 1701587: Add asserts to AutoTransactionSender to prevent storage of NULL pointers.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b6f7d477870
WIP: Bug 1701587: Add asserts to AutoTransactionSender to prevent storage of NULL pointers. r=kvark

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/3b6f7d477870

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Given the patch that landed, I don't think this was meant to be closed yet.

Comment 6

[Brad Werth [:bradwerth]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)

Given the patch that landed, I don't think this was meant to be closed yet.

Yes, that's correct. I should have set the leave-open keyword before landing. Thank you.

Comment 7

[Brad Werth [:bradwerth]]

Attachment: WIP: Bug 1701587 Part 2: Upgrade asserts in AutoTransactionSender to run in release builds.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdf687aa4b91
WIP: Bug 1701587 Part 2: Upgrade asserts in AutoTransactionSender to run in release builds. r=kvark

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/bdf687aa4b91

Comment 10

[Jim Mathies [:jimm]]

signature is expected to change.