Closed Bug 1701617 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 28278 - Don't adjust computed value for position:sticky

Categories

(Core :: DOM: CSS Object Model, task, P4)

task

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28278 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28278
Details from upstream follow.

b'Rune Lillesveen <futhark@chromium.org>' wrote:

Don't adjust computed value for position:sticky

Sticky positioning does not apply to certain table display types, but
should only affect the used value, not the computed.

Bug: 1192443
Change-Id: Ic6c57d85f07a1d1825964365631cdf4abf206cbd
Reviewed-on: https://chromium-review.googlesource.com/2790447
WPT-Export-Revision: e1d81c0d5646bcef60b1fced9f9807a084f4e0c9

Component: web-platform-tests → Layout: Positioned
Product: Testing → Core
Component: Layout: Positioned → DOM: CSS Object Model

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 1[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] 2[GitHub]
PASS: 1
FAIL: 2

Chrome

OK : 2
PASS: 1
FAIL: 2

Safari

OK : 2
PASS: 1
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-typed-om/the-stylepropertymap/computed/get-position.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
Computed position sticky even if it does not apply: FAIL (Chrome: FAIL, Safari: FAIL)
Computed position absolute even if it does not apply: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/css/css-typed-om/the-stylepropertymap/computed/get-position.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dec04967a0d4 [wpt PR 28278] - Don't adjust computed value for position:sticky, a=testonly https://hg.mozilla.org/integration/autoland/rev/f2b297e1670c [wpt PR 28278] - Update wpt metadata, a=testonly
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0e9b7ab9e766 [wpt PR 28278] - Don't adjust computed value for position:sticky, a=testonly https://hg.mozilla.org/integration/autoland/rev/bdfa16181776 [wpt PR 28278] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/23e48475a390 [wpt PR 28278] - Don't adjust computed value for position:sticky, a=testonly https://hg.mozilla.org/integration/autoland/rev/fd7d44f733f4 [wpt PR 28278] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/643f14a94c35 [wpt PR 28278] - Don't adjust computed value for position:sticky, a=testonly https://hg.mozilla.org/integration/autoland/rev/2c5b0bacc217 [wpt PR 28278] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.