Closed Bug 1701620 Opened 2 months ago Closed 29 days ago

wasi support part 4: add wasi branches for memory stuff

Categories

(Core :: JavaScript Engine, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: dbezhetskov, Assigned: dbezhetskov)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Blocks: 1701197

WASI lacks of support many memory stuff like mmap, memory protections and etc, but
it has malloc so we can use it instead. Also, here we are stubbing out all
uses of the missing WASI memory functionality.

Assignee: nobody → dbezhetskov
Severity: -- → N/A
Priority: -- → P2
Attachment #9212149 - Attachment description: Bug 1701620 - Fix memory support for WASI. r=jandem → Bug 1701620 part 4 - Fix memory support for WASI. r=jandem
Pushed by dbezhetskov@igalia.com:
https://hg.mozilla.org/integration/autoland/rev/f48cb748519b
part 4 - Fix memory support for WASI. r=jandem,sfink

Backed out for bustage on Memory.cpp

backout: https://hg.mozilla.org/integration/autoland/rev/0dc3628149f6d969450700ed1d9d4ac6f3124e76

push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=f48cb748519ba05ed785e89a55452d29afbd70d5&searchStr=win&group_state=expanded

failure log: https://treeherder.mozilla.org/logviewer?job_id=336322194&repo=autoland&lineNumber=21913

[task 2021-04-13T07:01:30.056Z] 07:01:30 INFO - In file included from Unified_cpp_js_src_gc1.cpp:11:
[task 2021-04-13T07:01:30.056Z] 07:01:30 INFO - /builds/worker/checkouts/gecko/js/src/gc/Memory.cpp(1004,62): error: use of undeclared identifier 'map'
[task 2021-04-13T07:01:30.056Z] 07:01:30 INFO - MOZ_RELEASE_ASSERT(UnmapViewOfFile(reinterpret_cast<void*>(map)) != 0);
[task 2021-04-13T07:01:30.056Z] 07:01:30 INFO - ^
[task 2021-04-13T07:01:30.056Z] 07:01:30 INFO - /builds/worker/checkouts/gecko/js/src/gc/Memory.cpp(1004,62): error: use of undeclared identifier 'map'
[task 2021-04-13T07:01:30.056Z] 07:01:30 INFO - 2 errors generated.
[task 2021-04-13T07:01:30.056Z] 07:01:30 ERROR - make[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:674: Unified_cpp_js_src_gc1.obj] Error 1
[task 2021-04-13T07:01:30.056Z] 07:01:30 INFO - make[4]: Leaving directory '/builds/worker/workspace/obj-build/js/src/gc'
[task 2021-04-13T07:01:30.057Z] 07:01:30 ERROR - make[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: js/src/gc/target-objects] Error 2

Flags: needinfo?(dbezhetskov)
Attachment #9212149 - Attachment description: Bug 1701620 part 4 - Fix memory support for WASI. r=jandem → Bug 1701620 part 4 - Fix memory support for WASI. r=jandem,sfink
Pushed by dbezhetskov@igalia.com:
https://hg.mozilla.org/integration/autoland/rev/d71266a031dc
part 4 - Fix memory support for WASI. r=jandem,sfink
Flags: needinfo?(dbezhetskov)
Status: UNCONFIRMED → RESOLVED
Closed: 29 days ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.