Closed Bug 1701625 Opened 8 months ago Closed 8 months ago

[Proton] The device name and "Remember this decision" strings are not aligned properly in the WebRTC Permission Panel

Categories

(Firefox :: Site Permissions, defect, P2)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
89 Branch
Tracking Status
firefox87 --- disabled
firefox88 --- disabled
firefox89 --- verified

People

(Reporter: tbabos, Assigned: emmamalysz)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-door-hangers][priority:2c])

Attachments

(3 files)

Attached image Proton ON.png

Tested on:
Nightly 89.0a1

TestedPlatform:
Windows 7
MacOS 10.15

Have the following prefs enabled:
browser.proton.enabled
browser.proton.doorhangers.enabled

Steps to reproduce:

  1. Open https://mozilla.github.io/webrtc-landing/gum_test.html
  2. Click on the Camera or Microphone button (make sure you have only 1 device connected for each)
  3. Check the alignment of the device name and the “Remember this decision” string

Expected Results:
The name of the device and the “Remember this decision” string should be aligned one under the other as in the Figma doc: https://www.figma.com/file/FjUe6ORvXZgJvI3rPuTV33/Desktop-UI-(Mozilla-Confidential-)?node-id=4561%3A40060

Actual Results:
The “Remember this decision” string is a few pixels more to the right compared to the device name string

Notes:
Disabling proton via (browser.proton.enabled) will still have a slight miss-alignment, but not so visible: See attached Image “Proton off” - browser.proton.doorhanger.enabled is still “true”.
This is reproducible for all WebRTC Permission Panels when only strings are displayed. (1 device of each type)

Attached image Proton off.png
Priority: -- → P3
Blocks: 1701680
No longer blocks: 1701680
Priority: P3 → P2
Assignee: nobody → emalysz
Status: NEW → ASSIGNED
Whiteboard: [proton-door-hangers] → [proton-door-hangers][priority:2c]
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0231751e65df
fix alignment for proton's WebRTC Permission Panel r=mconley
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

Verified-fixed on latest Firefox Nightly 89.0a1 (2021-04-01) (64-bit) on Windows 10 and MacOS 10.15.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.