1701625 - [Proton] The device name and "Remember this decision" strings are not aligned properly in the WebRTC Permission Panel

Status: VERIFIED FIXED

(Firefox :: Site Permissions, defect, P2)

Description

[Timea Cernea [:tbabos][inactive]]

Attachment: Proton ON.png

Tested on:
Nightly 89.0a1

TestedPlatform:
Windows 7
MacOS 10.15

Have the following prefs enabled:
browser.proton.enabled
browser.proton.doorhangers.enabled

Steps to reproduce:

1. Open https://mozilla.github.io/webrtc-landing/gum_test.html
2. Click on the Camera or Microphone button (make sure you have only 1 device connected for each)
3. Check the alignment of the device name and the “Remember this decision” string

Expected Results:
The name of the device and the “Remember this decision” string should be aligned one under the other as in the Figma doc: https://www.figma.com/file/FjUe6ORvXZgJvI3rPuTV33/Desktop-UI-(Mozilla-Confidential-)?node-id=4561%3A40060

Actual Results:
The “Remember this decision” string is a few pixels more to the right compared to the device name string

Notes:
Disabling proton via (browser.proton.enabled) will still have a slight miss-alignment, but not so visible: See attached Image “Proton off” - browser.proton.doorhanger.enabled is still “true”.
This is reproducible for all WebRTC Permission Panels when only strings are displayed. (1 device of each type)

Comment 1

[Timea Cernea [:tbabos][inactive]]

Attachment: Proton off.png

Comment 2

[Emma Malysz]

Attachment: Bug 1701625, fix alignment for proton's WebRTC Permission Panel

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0231751e65df
fix alignment for proton's WebRTC Permission Panel r=mconley

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0231751e65df

Comment 5

[Timea Cernea [:tbabos][inactive]]

Verified-fixed on latest Firefox Nightly 89.0a1 (2021-04-01) (64-bit) on Windows 10 and MacOS 10.15.