1701653 - add source filename to symbolication output

Status: RESOLVED FIXED

(Eliot :: General, enhancement, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Currently, symbolication with Eliot has the following output:

       {
            "frame": 8,
            "module": "XUL",
            "module_offset": "0x1081c27",
            "function": "mozilla::dom::ScriptElement::MaybeProcessScript()",
            "function_offset": "0x177",
            "line": 117
          },

One thing that's missing is the source filename.

For example, we get this output from minidump-stackwalk for Mozilla-owned frames:

{
    "file": "hg:hg.mozilla.org/releases/mozilla-release:dom/quota/ActorsParent.cpp:bb9bf7e886787222b18094a4723949a29b4d329a",
    "frame": 0,
    "function": "static mozilla::dom::quota::QuotaManager::Shutdown::<unnamed-tag>::operator()::<unnamed-tag>::__invoke(nsITimer*, void*)",
    "function_offset": "0x179",
    "line": 3683,
    "module": "xul.dll",
    "module_offset": "0x2509179",
    "offset": "0x4439179",
    "trust": "context"
},

Pretty sure the file part comes from the FILE records in the sym file. I'm pretty sure that's available via symbolic.

Having that information makes it possible to display stack information with links to the sources.

We should add it to the output of the symbolication v5 api implemented in Eliot.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

I'm pretty sure this is straight-forward to add. I'll try to do it this week.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 2329: bug 1701653: add "file" to symbolication API output

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #2329: "bug 1701653: add "file" to symbolication API output" in 52d109c.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

This is on stage now and works fine. Marking as FIXED.