Closed Bug 1701734 Opened 4 years ago Closed 4 years ago

Top-level dot files are not run through ESLint on continuous integration runs

Categories

(Developer Infrastructure :: Lint and Formatting, defect, P2)

Tracking

(firefox89 fixed)

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

If I run ./mach eslint locally on latest central, then I am seeing:

.eslintrc.js
  134:23  error  Replace `⏎········"security/manager/ssl/tests/mochitest/browser/**",⏎······` with `"security/manager/ssl/tests/mochitest/browser/**"`  prettier/prettier (eslint)

However this does not show on treeherder. Back in bug 1608535 when we implemented parallelism for ESLint, we added the * on the command to make the parallelism work. At some stage since then we've fixed it so that it happens by default.

We can therefore remove the * and have the top-level dot files linted as well.

Example try run, which shows the ES build at 8 minutes, approximately the same as on mozilla-central:

https://treeherder.mozilla.org/jobs?repo=try&revision=7d335a3ba0baff3c2a22632f6bc1ba24d5abc765&selectedTaskRun=V0KukGnRRA2v0ggR4QSmGQ.0

Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b36d7f2046f2 Re-enable ESLint on top-level dot files. r=ahal
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Has Regression Range: --- → yes
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: