1701785 - Browser Toolbox Inspector shows FX chrome stylesheets as inline

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Richard Marti (:Paenglab)]

Attachment: screenshot.png

In Nightly when I inspect FX's chrome with the Browser Toolbox Inspector it shows all rules as they come inline and not from different stylesheets.

On the right it should show browser.css instead of inline.

Clicking on it does also not go to Style editor and jump to the correct line.

Comment 1

[Julian Descottes [:jdescottes]]

Regression from Bug 1685268, and in particular from https://hg.mozilla.org/integration/autoland/rev/8c0ee03d5bb6

Interestingly if you move to this changeset, the issue happens regardless of the devtools.testing.enableServerWatcherSupport preference

Comment 2

[Julian Descottes [:jdescottes]]

This is coming from https://searchfox.org/mozilla-central/rev/0e3d2eb698a51006943f3b4fb74c035da80aa2ff/devtools/client/fronts/style-rule.js#113-114

    const resourceWatcher = this.targetFront.resourceWatcher;
    if (resourceWatcher) {

used to be

    const resourceWatcher = this.parentFront.resourceWatcher;
    if (resourceWatcher) {

Difference is minimal but with the previous implementation, parentFront.resourceWatcher was only defined if the resource watcher supported the STYLESHEET resource. With the new version, we assume that if we have a resource watcher, then we will have STYLESHEET resource support. Which is not true yet for the MBT.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1701785 - [devtools] Fix display of CSS rule sources in Browser Toolbox ruleview

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1685268

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb2ae885a63e
[devtools] Fix display of CSS rule sources in Browser Toolbox ruleview r=nchevobbe

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/fb2ae885a63e

Comment 7

[Giorgia Nichita, Release Desktop QA]

Hello,
I have reproduced the issue using STR from comment 0, on an affected Nightly build 2021-03-28.

The fix was verified using the latest Nightly 90.0a1 (2021-05-09) and Firefox 89.0b10 (2021-05-09) on Windows 10x64 and Ubuntu 20.04.
The issue is not reproducing anymore.

Thanks!