17018 - Check in a workaround for **long** Character Set menu

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[Katsuhiko Momoi]

As a way to workaround 1)non-scrollable and 2) non-customizable Character
Set menus in Messenger, Navigator, Editor, check in the diffs designated
as "M10 only" in the above URL.
Check in also the messengercompose.dtd diffs to normalize the Charset
menu names as well.

These files were tested and verified to work on the 10/19/99 Win32 build.

This is a simple re-arrangement of the Character Set menu, and it should
look like this image:

http://www.mozilla.org/quality/intl/m6/unixchamenu/charmenusample.gif

Comment 1

[Katsuhiko Momoi]

Jean-Francois, please review the diffs for Editor and Messenger
changes. I'll send you the diffs and explanation.

Comment 2

[Jean-Francois Ducarroz]

I have reviewed modifications for Messenger, Editor (html & plain text editor) and MessageCompose. Everything is
fine for me.
GO, check it in...

Comment 3

[Katsuhiko Momoi]

Cata, when your review of the Navigator diffs is done, please
check the whole thing in and mark this bug fixed.

Comment 4

[cata]

All diffs are in. Please QA it. Thanks!

Comment 5

[Katsuhiko Momoi]

Thanks, Cata.

This check-in affects charset menus in Navigator, Composer,
(Plain Text Editor -- if there is still one under Debug menu?),
Messenger, and Messenger Compose windows.

The Browser team, please look at Navigator and Composer/Editor menus.
The mail team should look at Messenger and MessengerCompose menus and
make sure that they all work.

I talked to teruko about Composer charset menu and apparently there is
a bug in the Save function such that everything is saved as UTF-8
even when the charset menu is changed. So the Composer menu probably
will not be all that effective until that bug is fixed.
teruko, do you know the bug number for the Save problem?

Comment 6

[Katsuhiko Momoi]

** Checked with 10/28/99 Win32 build (1999102808) **

Th new Messenger Menu and MessengerCompose menus now work OK
on Windows. The charset names also have been normalized
according to the Mozilla Charset UI name spec:

http://terra.mcom.com/eng/projects/new5.0/charset-ui-names.html

Marking it fixed.

We need verification for:

Messenger & MessengerCompose on Linux.
Browser & Editor on all platforms (teruko)

Thanks.

Comment 7

[Katsuhiko Momoi]

Xianglan, please look at Linux Mail menus and write in your findigns here.

Comment 8

[Katsuhiko Momoi]

Sorry there was a typo for the UI name for ISO-8859-13
in my original diffs. It should be "Baltic" rather than "Greek".
This is UI change only and will not affect the functionality  of this
menu item but we should correct it.

Please correct the following line:

<!ENTITY dcharIso13Cmd.label "Greek (ISO-8859-13)">

to

<!ENTITY dcharIso13Cmd.label "Baltic (ISO-8859-13)">

in the following 3 files:

/chrome/navigator/locale/en-US/navigator.dtd

/chrome/messenger/locale/en-US/messenger.dtd

/chrome/editor/locale/en-US/EditorOverlay.dtd

Re-opening the bug until this is fixed.

Comment 9

[cata]

Fixed. Please verify and close bug. Thanks!

Comment 10

[Katsuhiko Momoi]

There was one more typo.

The following should be corrected:

<!ENTITY dcharDosCyrCmd.label "Cyrillic (IBM866)">

To:

<!ENTITY dcharDosCyrCmd.label "Cyrillic (CP-866)">

in the following 3 files.
Thanks!

/chrome/navigator/locale/en-US/navigator.dtd

/chrome/messenger/locale/en-US/messenger.dtd

/chrome/editor/locale/en-US/EditorOverlay.dtd

Comment 11

[cata]

Done. Please verify and close.

Comment 12

[msanz]

Marking as fixed, for verification. Cata, that's what I understand from your
last comment, though you didn't mark the bug as such.

Comment 13

[Katsuhiko Momoi]

Look at tomorrow's build for CP-866 under Cyrillic rather than IBM866.

Comment 14

[ji]

Verified with today's linux build: 1999110309. It's fixed.

Comment 15

[Teruko Kobayashi]

I verified this in 110408 Mac and Win32 build.