1701802 - Win32k - *Many* calls to PeekMessage from SingleNativeEventPump::OnProcessNextEvent

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect, P2)

Description

[Chris Martin [:cmartin]]

This code is called a tonne. It basically spams the Win32k logs with calls that look like this:

win32u!NtUserPeekMessage
USER32!_PeekMessage+0x43
USER32!PeekMessageW+0x143
xul!mozilla::widget::WinUtils::PeekMessage+0xba [c:\moz\mozilla-central\widget\windows\WinUtils.cpp @ 735]
xul!SingleNativeEventPump::OnProcessNextEvent+0xd8 [c:\moz\mozilla-central\widget\windows\nsAppShell.cpp @ 309]
xul!nsThread::ProcessNextEvent+0x287 [c:\moz\mozilla-central\xpcom\threads\nsThread.cpp @ 1074]
xul!NS_ProcessNextEvent+0x65 [c:\moz\mozilla-central\xpcom\threads\nsThreadUtils.cpp @ 548]
xul!mozilla::ipc::MessagePump::Run+0x7c [c:\moz\mozilla-central\ipc\glue\MessagePump.cpp @ 88]
xul!MessageLoop::RunInternal+0x16 [c:\moz\mozilla-central\ipc\chromium\src\base\message_loop.cc @ 335]
xul!MessageLoop::RunHandler+0x50 [c:\moz\mozilla-central\ipc\chromium\src\base\message_loop.cc @ 329]
xul!MessageLoop::Run+0x58 [c:\moz\mozilla-central\ipc\chromium\src\base\message_loop.cc @ 311]
xul!nsBaseAppShell::Run+0x28 [c:\moz\mozilla-central\widget\nsBaseAppShell.cpp @ 139]
xul!nsAppShell::Run+0x1bc [c:\moz\mozilla-central\widget\windows\nsAppShell.cpp @ 602]
xul!XRE_RunAppShell+0x4c [c:\moz\mozilla-central\toolkit\xre\nsEmbedFunctions.cpp @ 902]
xul!MessageLoop::RunInternal+0x16 [c:\moz\mozilla-central\ipc\chromium\src\base\message_loop.cc @ 335]
xul!MessageLoop::RunHandler+0x50 [c:\moz\mozilla-central\ipc\chromium\src\base\message_loop.cc @ 329]
xul!MessageLoop::Run+0x58 [c:\moz\mozilla-central\ipc\chromium\src\base\message_loop.cc @ 311]
xul!XRE_InitChildProcess+0x6c9 [c:\moz\mozilla-central\toolkit\xre\nsEmbedFunctions.cpp @ 738]

Comment 1

[Bob Owen (:bobowen)]

https://treeherder.mozilla.org/jobs?repo=try&revision=43cf6fd470a5f7d966ce5c7764de5a95fcf5cf8d

Comment 2

[Bob Owen (:bobowen)]

Attachment: Bug 1701802: Don't use SingleNativeEventPump in windows app shell if win32k is locked down. r=handyman!

Depends on D112961

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee55297f011c
Don't use SingleNativeEventPump in windows app shell if win32k is locked down. r=handyman

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/ee55297f011c