Closed Bug 1701815 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 28291 - [css-grid] Fix WPT grid-flex-track-intrinsic-sizes-002.html

Categories

(Core :: Layout: Grid, task, P4)

Product:
Core
Component:
Layout: Grid
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28291 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28291
Details from upstream follow.

b'Oriol Brufau <obrufau@igalia.com>' wrote:

[css-grid] Fix WPT grid-flex-track-intrinsic-sizes-002.html

This test was checking that grid items not spanning any flex track with
an intrinsic min track sizing function would distribute its intrinsic
contribution in $11.5.3. That was according to the resolution from
https://github.com/w3c/csswg-drafts/issues/3705

However, that wasn't web compatible, so it was later amended in
https://github.com/w3c/csswg-drafts/issues/4783

Now, the intrinsic contributions of items spanning flex tracks must be
distributed in $11.5.4, even if none of the flex tracks is intrinsic.

This change makes the test pass in GridNG.

Bug: 1045599
Change-Id: Ibfb818dcc12a185e30d2824e9ca534069beb48ec
Reviewed-on: https://chromium-review.googlesource.com/2791426
WPT-Export-Revision: b010c6ff71aee4f4dfd7fd1372daf695b06a3102

Component: web-platform-tests → Layout: Grid
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 5 subtests

Status Summary

Firefox

OK : 1
PASS: 1
FAIL: 4

Chrome

OK : 1
PASS: 1
FAIL: 4

Safari

OK : 1
PASS: 1
FAIL: 4

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-002.html
'grid' with: grid-template-columns: 1fr auto auto auto; and grid-template-rows: 1fr auto auto auto;: FAIL (Chrome: FAIL, Safari: FAIL)
'grid' with: grid-template-columns: 1fr 1fr 1fr 1fr; and grid-template-rows: 1fr 1fr 1fr 1fr;: FAIL (Chrome: FAIL, Safari: FAIL)
'grid' with: grid-template-columns: 1fr 1fr 1fr 4fr; and grid-template-rows: 1fr 1fr 1fr 4fr;: FAIL (Chrome: FAIL, Safari: FAIL)
'grid' with: grid-template-columns: 1fr 1fr 1fr; and grid-template-rows: 1fr 1fr 1fr;: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c434e8ead44c [wpt PR 28291] - [css-grid] Fix WPT grid-flex-track-intrinsic-sizes-002.html, a=testonly https://hg.mozilla.org/integration/autoland/rev/04603d288a20 [wpt PR 28291] - Update wpt metadata, a=testonly
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ef4f569dd6ca [wpt PR 28291] - [css-grid] Fix WPT grid-flex-track-intrinsic-sizes-002.html, a=testonly https://hg.mozilla.org/integration/autoland/rev/81c2b3dfb8e0 [wpt PR 28291] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a4eec34b0dfa [wpt PR 28291] - [css-grid] Fix WPT grid-flex-track-intrinsic-sizes-002.html, a=testonly https://hg.mozilla.org/integration/autoland/rev/3a6339ea75ca [wpt PR 28291] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e248e58b632e [wpt PR 28291] - [css-grid] Fix WPT grid-flex-track-intrinsic-sizes-002.html, a=testonly https://hg.mozilla.org/integration/autoland/rev/c3812f3468ee [wpt PR 28291] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/e248e58b632e
https://hg.mozilla.org/mozilla-central/rev/c3812f3468ee

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.