1701864 - "Failed to send email" error every time after upgrade to 88.0b1

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Nazar Mokrynskyi]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

Updated to 88.0b1 and got new problems :(

1. Try to send email using Thunderbird for GMail account

Actual results:

Email is sent, but says it failed to do so

Expected results:

Should not say that it failed to send email if it didn't fail

Comment 1

[WaltS48 [:walts48]]

Why do I never have these problems when testing release candidates, or when using the application?

Sorry, I can't reproduce testing sending from my two Gmail accounts using 88.0b1 on Fedora 33 Workstation, Gnome desktop.

I'm not using it on a regular basis because reading binary newsgroups is broken.

Comment 2

[Nazar Mokrynskyi]

It is 100% reproducible for me with both GMail and iRedMail-based servers, so I don't think it is server-specific.
If there is any information I can provide to help with solution, let me know.

Comment 3

[Ping Chen [:rnons] (away)]

I had this problem once, then I started with a fresh new profile and the problem was gone. I didn't find the root cause. Would you mind trying a fresh profile?

Comment 4

[Nazar Mokrynskyi]

I would prefer to not create a fresh profile and lose all of the settings to be honest and the issue should ideally be solvable without creation of new profile.

Comment 5

[Ping Chen [:rnons] (away)]

Sure, I was trying to say use a fresh profile to test if the problem still exists. You can switch back to the current profile, and we can think of what to do next. Thanks.

Comment 6

[Ping Chen [:rnons] (away)]

Hi Nazar, can you tell me the value of mailnews.send.jsmodule and mailnews.smtp.jsmodule of your TB install? To find out, open the Preferences page, search for Config Editor, open it, then search for jsmodule.

They should both be true, if not, please set them to true and try sending again, thanks.

Comment 7

[Nazar Mokrynskyi]

"mailnews.send.jsmodule" was "false" because there was a regression I had to work around (https://bugzilla.mozilla.org/show_bug.cgi?id=1690957), "mailnews.smtp.jsmodule" is "true".
Setting "mailnews.send.jsmodule" to "true" again fixes the issue.

Comment 8

[Ping Chen [:rnons] (away)]

Thanks. So SmtpService.jsm doesn't work well with nsMsgSend.cpp, I didn't test that much. Will leave this open for a while.

Comment 9

[Ping Chen [:rnons] (away)]

Attachment: 1701864.patch

Comment 10

[Magnus Melin [:mkmelin]]

Comment on attachment 9213514 [details] [diff] [review]
1701864.patch

Looks good as well. r=mkmelin

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4ef66f2d7077
Prevent an error when using nsMsgSend.cpp together with SmtpService.jsm. r=mkmelin

Comment 12

[Ping Chen [:rnons] (away)]

Comment on attachment 9213514 [details] [diff] [review]
1701864.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1661694
User impact if declined: When mailnews.send.jsmodule=false && mailnews.smtp.jsmodule=true, an error is shown after sending.
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9213514 [details] [diff] [review]
1701864.patch

[Triage Comment]
Approved for beta

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 88.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/fac9799a3cc8