Closed Bug 1701865 Opened 3 years ago Closed 1 year ago

about:telemetry - better adjust media querries so that Section names don't touch elements from right side of page on resize/zoom

Categories

(Toolkit :: Telemetry, defect, P3)

defect

Tracking

()

VERIFIED FIXED
112 Branch
Tracking Status
firefox88 --- wontfix
firefox89 --- wontfix
firefox112 --- verified
firefox113 --- verified

People

(Reporter: cfogel, Assigned: patrickmcghen, Mentored)

Details

(Whiteboard: [good second bug][lang=css])

Attachments

(3 files)

Affected versions

  • 89.0a1(2021-03-28), 88.0b2;

Affected platforms

  • Ubuntu 20, Windows 10;

Steps to reproduce

  1. Launch Firefox, access about:telemetry#scalars-tab
  2. Grab the browser and shrink its width gradualy;

Expected result

  • page elements don't get overlapped and have spacing across various sizes;

Actual result

  • Scalars(section name) touches Current Store(element from right side of page) on certain page-widths;
  • main issue being that text is next to text;

Regression range

  • will check and provide one asap;

Additional notes

  • attached screenshot to best illustrate the issue;
  • same for Keyed Scalars, Histograms, Keyed Histograms;
Has Regression Range: --- → no
Has STR: --- → yes

It is very likely this extends back very far (back to about:telemetry's redesign in the summer of 2017), so it need not have a firm regression range.

Mentor: chutten
Priority: -- → P3
Whiteboard: [good second bug][lang=css]

Hey, I wanted to propose a fix for this issue (it's very small but I think it should do the trick) but when I try to push I am asked to merge it with another head as I cannot create a new one. I'm not entirely sure how best to manage this?

(In reply to maaike.dumont from comment #2)

Hey, I wanted to propose a fix for this issue (it's very small but I think it should do the trick) but when I try to push I am asked to merge it with another head as I cannot create a new one. I'm not entirely sure how best to manage this?

Hey, you will need an account on https://phabricator.services.mozilla.com/ and then use moz-phab to submit your changes. See the Phabricator User Guide for details.

Flags: needinfo?(maaike.dumont)

Yes I have an account and also did moz-phab install-certificate but it's still not letting me push anything. Tempted to just do a clean install after work :)

Flags: needinfo?(maaike.dumont)
Assignee: nobody → holaszyd1
Status: NEW → ASSIGNED
Attachment #9247213 - Attachment description: Bug 1701865- adjusting media querries so that Section names don't touch elements from right side of page on resize/zoom r?chutten → Bug 1701865- adjusting media querries so that Section names don't touch elements from right side of page on resize/zoom and inline-start r?chutten

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Assignee: holaszyd1 → nobody
Status: ASSIGNED → NEW

I'd like to finish this one up.

By all means, please do! If you submit a patch, the bots ought to assign this bug to you.

Assignee: nobody → pmcghen
Status: NEW → ASSIGNED
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/687be451c557
Add margin-inline-start to sectionFilters r=chutten
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
QA Whiteboard: [qa-112b-p2]

Reproduced this issue on an affected Nightly build from 2021-03-29, using the STR from Comment 0 on Win 10.
Verified as fixed on Firefox 112.0b9 (20230330182947) and Firefox 113.0a1 (20230403092724) across the following platforms: Win 10 x64, Ubuntu 20.04 and macOS 10.15.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.