1701865 - about:telemetry - better adjust media querries so that Section names don't touch elements from right side of page on resize/zoom

Status: VERIFIED FIXED

(Toolkit :: Telemetry, defect, P3)

Description

[Cristian Fogel [:cfogel]]

Attachment: Screenshot from 2021-03-30 06-23-20.png

Affected versions

• 89.0a1(2021-03-28), 88.0b2;

Affected platforms

• Ubuntu 20, Windows 10;

Steps to reproduce

1. Launch Firefox, access about:telemetry#scalars-tab
2. Grab the browser and shrink its width gradualy;

Expected result

• page elements don't get overlapped and have spacing across various sizes;

Actual result

• Scalars(section name) touches Current Store(element from right side of page) on certain page-widths;
• main issue being that text is next to text;

Regression range

• will check and provide one asap;

Additional notes

• attached screenshot to best illustrate the issue;
• same for Keyed Scalars, Histograms, Keyed Histograms;

Comment 1

[Chris H-C :chutten]

It is very likely this extends back very far (back to about:telemetry's redesign in the summer of 2017), so it need not have a firm regression range.

Comment 2

[maaike.dumont]

Hey, I wanted to propose a fix for this issue (it's very small but I think it should do the trick) but when I try to push I am asked to merge it with another head as I cannot create a new one. I'm not entirely sure how best to manage this?

Comment 3

[Jan-Erik Rediger [:janerik] (Away until 2024-12-23)]

(In reply to maaike.dumont from comment #2)

Hey, I wanted to propose a fix for this issue (it's very small but I think it should do the trick) but when I try to push I am asked to merge it with another head as I cannot create a new one. I'm not entirely sure how best to manage this?

Hey, you will need an account on https://phabricator.services.mozilla.com/ and then use moz-phab to submit your changes. See the Phabricator User Guide for details.

Comment 4

[maaike.dumont]

Yes I have an account and also did moz-phab install-certificate but it's still not letting me push anything. Tempted to just do a clean install after work :)

Comment 5

[ola-oluwa]

Attachment: Bug 1701865- adjusting media querries so that Section names don't touch elements from right side of page on resize/zoom and inline-start r?chutten

Depends on D129223

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 7

[Pat McGhen]

I'd like to finish this one up.

Comment 8

[Chris H-C :chutten]

By all means, please do! If you submit a patch, the bots ought to assign this bug to you.

Comment 9

[Pat McGhen]

Attachment: Bug 1701865 - Add margin-inline-start to sectionFilters r?chutten

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/687be451c557
Add margin-inline-start to sectionFilters r=chutten

Comment 11

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/687be451c557

Comment 12

[Giorgia Nichita, Release Desktop QA]

Reproduced this issue on an affected Nightly build from 2021-03-29, using the STR from Comment 0 on Win 10.
Verified as fixed on Firefox 112.0b9 (20230330182947) and Firefox 113.0a1 (20230403092724) across the following platforms: Win 10 x64, Ubuntu 20.04 and macOS 10.15.