1701868 - Support opaque response blocking when content type is recognized in OnDataAvailable()

Status: RESOLVED FIXED

(Core :: DOM: Networking, task, P1)

Description

[Eden Chuang[:edenchuang]]

Opaque Response Blocking logic executes when a channel is OnStartRequest stage.
However, it might have enough data/information to recognize the actual content type. And the logic can be passed as followings types
Allowed_UnexpectedResponseHead
Allowed_FailtoGetMIMEType
Allowed_NotImplementOrPass

But the content type could be recognized during OnDataAvailable stage by sniffing with UnknownDecoder. The opaque response blocking should execute again when the actual content type is recognized.

Comment 1

[Eden Chuang[:edenchuang]]

Attachment: Bug 1701868 - Opaque response blocking after UnknownDecoder recognizes the allowed or blocked type.

The original implementation concept of Opaque Response Blocking is trying to recognize the blocked or allowed content type in nsHttpChannel::CallOnStartRequest. However, the data could be not available at the moment for type sniffing. And nsUnknownDecoder could be used for type sniffing when OnDataAvailable is called.

So this patch targets this case and applying Opaque Response Blocking after the type is recognized by nsUnknownDecoder.

Comment 2

[Eden Chuang[:edenchuang]]

Attachment: Bug 1701868 - Testcase for OpaqueResponseBlocking with type sniffing fail.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a282dee4cdc
Testcase for OpaqueResponseBlocking with type sniffing fail. r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/27ab35eef920
Opaque response blocking after UnknownDecoder recognizes the allowed or blocked type. r=necko-reviewers,dragana

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3a282dee4cdc
https://hg.mozilla.org/mozilla-central/rev/27ab35eef920