1701897 - Make check for redundant property changes more precise

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jan de Mooij [:jandem]]

In putDataProperty and putAccessorProperty we check for redundant 'puts' like this:

  if (shape->matchesParamsAfterId(obj->lastProperty()->base(), objectFlags,
                                  slot, attrs, ...)) {
    return shape;
  }

However, the BaseShape and ObjectFlags are relevant for the last property's shape and not the shape of the property we're changing.

I ran into this in bug 1700052 when I expected a test failure but the test passed because we reshaped the object due to this bug.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1701897 - Make check for redundant property changes more precise. r?jonco!

The object flags are only relevant for the last property's shape. Comparing them
to the flags stored in the property's shape could result in doing unnecessary work
in certain (actually redundant) cases.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b66357775105
Make check for redundant property changes more precise. r=jonco

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b66357775105