1701924 - Partial inline reminder no longer shown

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Kai Engert [:KaiE:]]

If a message is partially encrypted, we show a notification, with a button, to manually request decryption.

When clicked, we intend to replace the notification message, with a reminder, that only a subset of the original message is shown.

Bug 1681887 introduced a regression, which caused the notification to no longer be replaced.

The problem was caused by a bad change to the button notification callback function. By changing the function to async, we don't close the original notification, which results in the original notification to remain visible.

The callback doesn't need to be async. Changing it back to sync fixes the bug.

Comment 1

[Kai Engert [:KaiE:]]

Attachment: Bug 1701924 - Reenable reminder for partially encrypted messages. r=mkmelin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5060f4fffb67
Reenable reminder for partially encrypted messages. r=mkmelin

Comment 3

[Kai Engert [:KaiE:]]

Comment on attachment 9212482 [details]
Bug 1701924 - Reenable reminder for partially encrypted messages. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): 1681887
User impact if declined: important reminder is not shown
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Kai Engert [:KaiE:]]

Comment on attachment 9212482 [details]
Bug 1701924 - Reenable reminder for partially encrypted messages. r=mkmelin

See above beta approval request for details.

Requesting esr78 approval, however, should wait for at least 2 weeks beta testing.

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9212482 [details]
Bug 1701924 - Reenable reminder for partially encrypted messages. r=mkmelin

[Triage Comment]
Approved for beta

Comment 6

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/releases/comm-beta/rev/d63ba760fc0b8e822448498f7c71142b3feb761b
89.0b3

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9212482 [details]
Bug 1701924 - Reenable reminder for partially encrypted messages. r=mkmelin

[Triage Comment]
Approved for esr78

Comment 8

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/releases/comm-esr78/rev/ac7bb1415861861c0d62212e226ccf1d5ba55f26
78.10.2