Bookmarked favicon has white background while the actual favicon does not
Categories
(Firefox :: Bookmarks & History, defect)
Tracking
()
People
(Reporter: nico9824, Unassigned)
Details
Attachments
(1 file)
|
12.73 KB,
image/png
|
Details |
favicons.png
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:87.0) Gecko/20100101 Firefox/87.0
Steps to reproduce:
Bookmark a site to my bookmarks bar
Actual results:
The site's favicon has a white background
Expected results:
The site's favicon should not have a background
(Happens only on my laptop and not on my desktop PC)
|
||
Comment 1•4 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.
|
Reporter | |
Comment 2•4 years ago
|
||
Seem to be a 4k Screen Issue. When i change my resolution to 1080p there is no background
|
||
Comment 3•4 years ago
|
||
The reason is that a different icon is picked depending on the resolution/dpi ratio.
The page provides this 32px icon: https://www.chess.com/bundles/web/favicons/favicon-32x32.c2a8280d.png
and this 16px icon: https://www.chess.com/bundles/web/favicons/favicon-16x16.31f99381.png
These have transparent background, so no problem, and it's the icon shown in 1080p.
Then it also provides this other icon: https://www.chess.com/bundles/web/favicons/apple-touch-icon.f72d3fd3.png
This has a white background, probably because it's supposed to be used for a button.
At 4k, we're likely requesting a 48px icon (16px * 4), and we end up picking the last one that is 180x180, to avoid pixelating the 32x32 icon.
Bug 1494016 would improve this by picking the 32x32 icon, because 180x180 is too far away from 48x48.
The tab instead is using the svg favicon, but due to bug 1337397 we don't yet cache svg mask-icons.
So, in the end this is a mixture of bug 1337397 and bug 1494016. I'll dupe to bug 1494016 for now.
Description
•