1701948 - Early startup cache should work for Nimbus remote defaults

Status: RESOLVED FIXED

(Firefox :: Nimbus Desktop Client, enhancement, P1)

Description

[Kate Hudson :k88hudson]

We should minimize the overhead (i.e. reuse the same set of prefs if we can), but we don't want to run into any race conditions with experiments

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1701948 - Early startup cache should work for Nimbus remote defaults

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90163e505c3f
Early startup cache should work for Nimbus remote defaults r=k88hudson

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on browser_remotesettingsexperimentloader_remote_defaults.js

backout: https://hg.mozilla.org/integration/autoland/rev/738fa8ffae10a03b7d9312ca7931feef888f66ba

push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=90163e505c3fbcd52815d34b1f9f0bea110b2099&searchStr=bc&selectedTaskRun=J0380hkWQjSILq6eKxjaeg.0

failure log: https://treeherder.mozilla.org/logviewer?job_id=336692943&repo=autoland&lineNumber=2367

[task 2021-04-15T18:26:33.368Z] 18:26:33 INFO - TEST-PASS | toolkit/components/nimbus/test/browser/browser_remotesettingsexperimentloader_remote_defaults.js | This prop does not exist before we sync - "undefined" == "undefined" -
[task 2021-04-15T18:26:33.369Z] 18:26:33 INFO - Console message: [JavaScript Error: "Unknown Collection "main/nimbus-desktop-defaults"" {file: "resource://services-settings/RemoteSettingsClient.jsm" line: 160}]
[task 2021-04-15T18:26:33.370Z] 18:26:33 INFO - UnknownCollectionError@resource://services-settings/RemoteSettingsClient.jsm:160:5
[task 2021-04-15T18:26:33.371Z] 18:26:33 INFO - sync@resource://services-settings/RemoteSettingsClient.jsm:470:13
[task 2021-04-15T18:26:33.372Z] 18:26:33 INFO -
[task 2021-04-15T18:26:33.372Z] 18:26:33 INFO - Buffered messages finished
[task 2021-04-15T18:26:33.373Z] 18:26:33 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/nimbus/test/browser/browser_remotesettingsexperimentloader_remote_defaults.js | Called finalize after processing remote configs - false == true - JS frame :: chrome://mochitests/content/browser/toolkit/components/nimbus/test/browser/browser_remotesettingsexperimentloader_remote_defaults.js :: test_remote_fetch_and_ready :: line 108
[task 2021-04-15T18:26:33.374Z] 18:26:33 INFO - Stack trace:
[task 2021-04-15T18:26:33.375Z] 18:26:33 INFO - chrome://mochitests/content/browser/toolkit/components/nimbus/test/browser/browser_remotesettingsexperimentloader_remote_defaults.js:test_remote_fetch_and_ready:108
[task 2021-04-15T18:26:33.376Z] 18:26:33 INFO - TEST-PASS | toolkit/components/nimbus/test/browser/browser_remotesettingsexperimentloader_remote_defaults.js | Enabled by remote defaults - true == true -
[task 2021-04-15T18:26:33.376Z] 18:26:33 INFO - TEST-PASS | toolkit/components/nimbus/test/browser/browser_remotesettingsexperimentloader_remote_defaults.js | Set by remote defaults - 42 == 42 -

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/137846a06233
Early startup cache should work for Nimbus remote defaults r=k88hudson

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/137846a06233