1701990 - Remove 'Drag Space' option from Customize mode

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, task, P3)

Description

[Jared Wein [:jaws] (please needinfo? me)]

UX review of the Tabs for MR1 specifies Drag Space should be removed from Customize mode.

Comment 1

[Michael Kohler [:mkohler]]

Is the goal here to not show the Drag Space checkbox and label when Proton is enabled? Or do we completely remove the functionality assuming Proton will stick anyway?

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Michael Kohler [:mkohler] from comment #1)

Is the goal here to not show the Drag Space checkbox and label when Proton is enabled? Or do we completely remove the functionality assuming Proton will stick anyway?

We should remove functionality but keep the pref around. If we decided to add it back we can revert the patch here, and as long as we don't remove the pref we won't need to worry about migrating users.

Comment 3

[Michael Kohler [:mkohler]]

Attachment: Bug 1701990 - Remove Drag Space r=Gijs

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ee25a7f42f2
Remove Drag Space r=desktop-theme-reviewers,dao

Comment 6

[Atila Butkovits]

Backed out for causing failures at browser_970511_undo_restore_default.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/db07bdd11e66aa113b9ef701d8548364a61e177b

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=NYCqzodYQJa4W_I7XKvHgA.0&revision=2ee25a7f42f2cd054055b2578fa11c24bc6f641b&searchStr=linux%2C18.04%2Cx64%2Ctsan%2Copt%2Cmochitests%2Ctest-linux1804-64-tsan%2Fopt-mochitest-browser-chrome-e10s%2Cbc14

Failure log: https://treeherder.mozilla.org/logviewer?job_id=336059266&repo=autoland&lineNumber=2760

Comment 7

[Michael Kohler [:mkohler]]

Oh no, fixed push to the revision. Don't see any related failures on https://treeherder.mozilla.org/jobs?repo=try&revision=0907b3ce29e39a286f930ec2096fa3b8d792a2d6&selectedTaskRun=Bs25gbT2RIyBGTQd6eJ4QQ.0 now.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cd252982618
Remove Drag Space r=desktop-theme-reviewers,dao

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3cd252982618

Comment 10

[Troy Janda]

I wanted to stop by and say thanks!

I have over 300 students and staff leaving trouble tickets because of the missing drag space and missing Compact Mode. Tired of you guys removing stuff because you think that people are not using it or there is not enough people using it. This is a sure way of losing even more user base you clowns. Been a loyal fan for years and use Firefox exclusively, however over the last year+ been contemplating switching.

I would like to know how to re-enable both features

Comment 11

[Hani Yacoub, Desktop QA]

Verified as fixed on Windows 10 x64, macOS 10.15, Ubuntu 20.04 and on Windows 7 x64.