1702012 - move symbolic-utils functions to new module

Status: RESOLVED FIXED

(Eliot :: General, task, P3)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

The symbolicate_resource.py module has a lot of stuff in it and some of it would be better in a separate module of Breakpad SYM and symbolic utility functions.

• bytes_split_generator
• get_module_filename
• converting from a debug_filename to the sym filename
• converting from sym to symcache
• converting from a Lineinfo to a filepath

Probably some other things, too.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 2396: bug 1702012: split out symbolic wrapper

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #2396: "bug 1702012: split out symbolic wrapper" in cff2c20.

This is in the eliot-dev branch. After codefreeze is over, I'll merge it to main.

One note is that I didn't move the lineinfo -> data frame code over. The shape of the data frame is specific to the API version, so it seemed like that belongs in the view and not the wrapper.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

This merged to main and deployed to stage so we're good here.