Closed Bug 1702018 Opened 3 years ago Closed 3 years ago

Proton: Mouse/Keyboard hovering on a one-off has almost the same color

Categories

(Firefox :: Address Bar, defect, P5)

Desktop
All
defect

Tracking

()

RESOLVED DUPLICATE of bug 1702772
Tracking Status
firefox87 --- unaffected
firefox88 --- unaffected
firefox89 --- affected

People

(Reporter: muirpablo, Unassigned)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proton-address-bar])

Attachments

(1 file)

Attached image hovering.jpg

Mouse/Keyboard hovering on a one-off has almost the same color

Tested on
Windows10 64bit , MacOS 10.14, Ubuntu 20, affected on all.
with firefox nightly 89.0a1

steps

  1. Enable Proton.
    user_pref("browser.proton.enabled", true);
    user_pref("browser.proton.toolbar.enable", true);
    user_pref("browser.proton.urlbar.enabled", true);

  2. Change theme to light theme

  3. Type something in address bar

  4. Hover with mouse over one of the one-offs

  5. press down key many times, untill you reach another one-off

  6. Check color differences.

actual result

light theme: mouse and keyboard one-off hovering have almost same color (on ubuntu not affected since it is orange)
default : mouse and keyaboard one-off hovering have almost same color
Dark theme: mouse is light black, and keyboard is completely dark
alpenglow: mouse and keyaboard one-off hovering have almost same color

expected result
there should be a clear difference between selecting a one off with the mouse and selecting it with the keyboard.

Hi romain, could you please set a priority for this here?

Severity: -- → S3
Flags: needinfo?(rtestard)
Whiteboard: [proton-address-bar]

is this a bug or enh request?
This looks to be correct according to the spec, we may consider this a spec bug if we want to change the colors.

Hi marco

I opened it as a bug because:

  1. there is a clear difference in color when you hover with mouse and hover with keyboard on Search suggestions
  2. there is no clear difference when you hover with mouse and hover with keyboard on the One-offs buttons.

Marking as P5 for now and NIing Amy to clarify if this is something we should consider adjusting.

Flags: needinfo?(rtestard)
Priority: -- → P5

Amy, can you please clarify if this suggestion makes sense or if we should close the bug?

Flags: needinfo?(amlee)

Hi,

These are the colours for

hover mouse - #F0F0F4
hover keyboard - #E0E0E6

If these are implemented correctly then I would say no change. Thanks

Flags: needinfo?(amlee)

(In reply to Amy Lee [:amylee] UX from comment #6)

hover mouse - #F0F0F4
hover keyboard - #E0E0E6

If these are implemented correctly then I would say no change. Thanks

Just took a screenshot and color picked it, the colors are exactly those.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX

Nevermind, I measured results, not one-off buttons, there is a bug on one-off buttons but it's the same as bug 1702772

Resolution: WONTFIX → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: