170221 - Syntax error opening message security info

Status: VERIFIED FIXED

(MailNews Core :: Security, defect)

Description

[Tuukka Tolvanen (sp3000)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2b) Gecko/20020921 Phoenix/0.1
Build Identifier: linux trunk cvs 2002-09-22

.

Reproducible: Always

Steps to Reproduce:
 1. in mailnews, select a message
 2. view > security info

Actual Results:  
Blank dialog with ok cancel help buttons only;

Error: syntax error
Source File: chrome://messenger-smime/content/msgReadSecurityInfo.js
Line: 238, Column: 5
Source Code:
  cd->viewCert(parent, cert);

Error: onLoad is not defined


Expected Results:  
Useful dialog, no errors

<sodapop3k> um, "->" is nonsense in js right?
<ssieb_home> sodapop3k: yes

$ find mozilla/ -name "*.js" -exec egrep --with-filename -- "->" "{}" \; | egrep
"[^-]->" | egrep --invert-match "^[^:]*:[[:space:]]*//"
    ...comments & strings clipped...
mozilla/mailnews/extensions/smime/resources/content/msgReadSecurityInfo.js: 
cd->viewCert(parent, cert);
mozilla/mailnews/extensions/smime/resources/content/msgCompSecurityInfo.js: 
cd->viewCert(parent, cert);

Comment 1

[Tuukka Tolvanen (sp3000)]

->kaie (cvsblame)

Comment 2

[Kai Engert [:KaiE:]]

Attachment: Obvious Patch v1

Comment 3

[Kai Engert [:KaiE:]]

Alec, Javi, could you please r/sr this tiny obvious patch?

Comment 4

[Javier Delgadillo]

Comment on attachment 100230 [details] [diff] [review]
Obvious Patch v1

r=javi

Comment 5

[rpotts (gone)]

Comment on attachment 100230 [details] [diff] [review]
Obvious Patch v1

sr=[e-mail]

Comment 6

[Kai Engert [:KaiE:]]

Fixed on trunk.

Comment 7

[John Unruh]

V