Closed Bug 1702231 Opened 3 years ago Closed 3 years ago

Fix webext tests that fail with BFCache+Fission

Categories

(WebExtensions :: General, defect, P2)

defect

Tracking

(Fission Milestone:M7a, firefox90 fixed)

RESOLVED FIXED
90 Branch
Fission Milestone M7a
Tracking Status
firefox90 --- fixed

People

(Reporter: neha, Assigned: zombie)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file, 1 obsolete file)

When BFCache is enabled for Fission, these tests fail:
toolkit/mozapps/extensions/test/xpinstall/browser_enabled.js
toolkit/mozapps/extensions/test/xpinstall/browser_enabled2.js
toolkit/mozapps/extensions/test/xpinstall/browser_enabled3.js
toolkit/mozapps/extensions/test/xpinstall/browser_hash.js
toolkit/mozapps/extensions/test/xpinstall/browser_hash2.js
toolkit/mozapps/extensions/test/xpinstall/browser_httphash.js
toolkit/mozapps/extensions/test/xpinstall/browser_httphash2.js
toolkit/mozapps/extensions/test/xpinstall/browser_httphash3.js
toolkit/mozapps/extensions/test/xpinstall/browser_httphash4.js
toolkit/mozapps/extensions/test/xpinstall/browser_httphash5.js
toolkit/mozapps/extensions/test/xpinstall/browser_installchrome.js
toolkit/mozapps/extensions/test/xpinstall/browser_localfile.js

Pref to use: fission.bfcacheInParent

try: https://treeherder.mozilla.org/jobs?repo=try&revision=1718aea0a82a5fb84eb8117252fc0436442758c4&selectedTaskRun=ENV4BTNzQbCtmyr7gbHNjA.0

Fission Milestone: --- → M7a
Flags: needinfo?(tomica)

Is that the correct try link? I didn't see any failures in mozapps.

Flags: needinfo?(nkochar)
Assignee: nobody → tomica
Severity: -- → S3
Flags: needinfo?(tomica)
Priority: -- → P2

:zombie, these tests are also failing:
browser/components/extensions/test/browser/browser_ext_devtools_inspectedWindow_targetSwitch.js
browser/components/extensions/test/browser/browser_ext_devtools_network_targetSwitch.js
browser/components/extensions/test/browser/browser_ext_find.js
browser/components/extensions/test/browser/browser_ext_openPanel.js

Flags: needinfo?(nkochar)
Attachment #9215291 - Attachment is obsolete: true

With bfcacheInParent enabled, frameloader gets replaced on (each?) navigation,
and now a ContentTask script can't listen for "load" events after navigating.

Solution is to split the big ContentTask script into smaller ones, and use
BrowserTestUtils.waitForContentEvent which works across frameloaders being
replaced.

Pushed by tjovanovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d733983ca05e
Make InstallTrigger tests work with BFcache in parent r=mixedpuppy
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: