1702235 - Put "separate tags with commas" below the tags text input in the Bookmarks Panel

Status: NEW

(Firefox :: Bookmarks & History, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

The UX spec calls for this text to no longer be placeholder text, but to be "caption" text that appears beneath the text input at a slightly smaller font.

Comment 1

[Michael Kohler [:mkohler]]

Attachment: 2022-06-05.png

Hi Mike, this is how this currently looks in the edit mode. Is this change also desired there? Should it be added to the existing caption text?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

I think I'm going to defer this to Meridel - is this still something we wanted to do? I believe this bug was based on the slide from this deck: https://docs.google.com/presentation/d/1B8DGptLZLsiU_KF6rV9XeIgd9BJquLFhYVqrt7I-LdU/edit#slide=id.gbc9459a088_1_131

Comment 3

[Meridel [:meridel]]

In both Add and Edit modes, "Separate tags with commas" should be caption text and not placeholder text.

Slide 19, Add Bookmark: https://docs.google.com/presentation/d/1B8DGptLZLsiU_KF6rV9XeIgd9BJquLFhYVqrt7I-LdU/edit#slide=id.gbc9459a088_1_131

Slide 20, Edit Bookmark: https://docs.google.com/presentation/d/1B8DGptLZLsiU_KF6rV9XeIgd9BJquLFhYVqrt7I-LdU/edit#slide=id.gc0772ae679_11_31

Comment 4

[Michael Kohler [:mkohler]]

Attachment: image.png

Thanks for the info. Makes sense in the add/edit panel. Should the same change be done in the "Edit bookmark" dialog as well? Right-click an existing bookmark in the Bookmarks panel -> Edit bookmark... menu item. If that should be changed, what should be done with the existing sublabel?

Here's a screenshot with a bit more context than the previous one.

Additionally, are there specifications on font size and color?

Comment 5

[Meridel [:meridel]]

What's the difference between the "add/edit" panel and the "Edit bookmark" dialog? How trigger the latter?

Comment 6

[Michael Kohler [:mkohler]]

Attachment: screenshot of the bookmarks context menu

The "Edit bookmark" dialog is outside of the "add/edit" panel you get when clicking on the star icon. To get to the "Edit bookmark" dialog, you can follow either of these paths:

1. Create a bookmark
2. Open the Library panel by clicking on the "Library" toolbar button
3. Choose bookmarks
4. Right click on the existing bookmark
5. Choose "Edit bookmark..."

or

1. Create a bookmark
2. Open the Bookmarks by clicking on the "Bookmarks" toolbar button
3. Right click on the existing bookmark
4. Choose "Edit bookmark..."

Screenshot of the context menu attached. Hope this helps :)

Comment 7

[Meridel [:meridel]]

Ah, I see. Yes, I would expect the labels in the Library view to mimic what we do in the Edit panel (see crude mock: https://docs.google.com/presentation/d/1B8DGptLZLsiU_KF6rV9XeIgd9BJquLFhYVqrt7I-LdU/edit#slide=id.g13d7b5b6ac3_1_0)

However, changes to library were not in scope for our MR1 redesign, and I am not sure we want to start making updates now as the entire library is in need of a redesign and was not thought through holistically for the MR1 changes.

Romain, can you please advise as to whether changes should be made here?

Note, questions about font size or color would need UX design input.