1702240 - Change nsDocShell's notification of keyword-search pass a string rather than an engine

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

If we pass a string for the engine name in the keyword-search notification, then nsDocShell will no longer need to import the search service. This will help with potentially changing the search service to not be an XPCOM service (bug 1643008). It is still slightly TBD if we do make the change or not, but I think this is a useful simplification.

The keyword-search notification and handler can be found here: https://searchfox.org/mozilla-central/search?q=keyword-search&path=*&case=false&regexp=false

nsDocShell::MaybeNotifyKeywordSearchLoading should be changed to pass aProvider as the first argument, however, that needs to be wrapped into a nsISupports interface, e.g. example here.

On the JavaScript side, I think we can use Services.search.getEngineByName(subject.data) to get the engine object.

Comment 1

[mgroot]

I would like to try to fix this issue.

Comment 2

[Mark Banner (:standard8)]

(In reply to mgroot from comment #1)

I would like to try to fix this issue.

Sure. Thank you for the offer.

Comment 3

[Mark Banner (:standard8)]

:mgroot, are you still working on this?

Comment 4

[mgroot]

I am, but I have little time at the moment so if it is high priority feel free to reassign.

Comment 5

[Mark Banner (:standard8)]

(In reply to mgroot from comment #4)

I am, but I have little time at the moment so if it is high priority feel free to reassign.

That is fine, this isn't high priority at the moment, so just wanted to check. Just let us know if anything changes. If you need help let us know.

Comment 6

[Mark Banner (:standard8)]

Opening this up for others, as mgroot hasn't had time to get to it.

Comment 7

[Jane Kotovich (:janey)]

Hey guys! Would love to work on this one!

Comment 8

[Jane Kotovich (:janey)]

Attachment: Bug 1702240. Change nsDocShell's notification of keyword-search pass a string rather than an engine. r=standard8

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7987621675da
Change nsDocShell's notification of keyword-search pass a string rather than an engine. r=Standard8

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7987621675da