Closed
Bug 1702248
Opened 3 years ago
Closed 3 years ago
Limit the encoding_detection_outcome_html and encoding_detection_outcome_text probes to top-level navigations
Categories
(Core :: DOM: HTML Parser, task, P2)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
89 Branch
People
(Reporter: hsivonen, Assigned: hsivonen)
References
Details
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
The data from these probes may be contaminated by advertising iframes. Limiting these to top-level navigations will probably give a better idea of the status of the documents that the user wants to read. (As opposed to documents that contain a lot of code, an image, and perhaps some copyright footer.)
Assignee | ||
Comment 1•3 years ago
|
||
See https://hsivonen.fi/encoding-telemetry/ for the telemetry numbers.
Assignee | ||
Comment 2•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Assignee: nobody → hsivonen
Severity: -- → N/A
Status: NEW → ASSIGNED
Priority: -- → P2
Pushed by hsivonen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/13ca1a60775d Limit encoding detection outcome telemetry to top level and to text/html and text/plain. r=emk
Comment 4•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox89:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Assignee | ||
Comment 5•3 years ago
|
||
Comment on attachment 9213729 [details]
Bug 1702248 - Limit encoding detection outcome telemetry to top level and to text/html and text/plain.
Beta/Release Uplift Approval Request
- User impact if declined: Future product improvement may be delayed by one release cycle. (Uplifting this allows for telemetry analysis one release cycle earlier.)
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This merely reduces telemetry collection.
- String changes made/needed: None
Attachment #9213729 -
Flags: approval-mozilla-beta?
Comment 6•3 years ago
|
||
Comment on attachment 9213729 [details]
Bug 1702248 - Limit encoding detection outcome telemetry to top level and to text/html and text/plain.
Approved for 88.0b9.
Attachment #9213729 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 7•3 years ago
|
||
bugherder uplift |
status-firefox88:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•