1702278 - Manage Debug Metadata separately from CompileOptions

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

CompileOptions has a whole spectrum of responsibilities that make it a complicated interface to handle.

We would like to strip it of some of its responsibilities. One facet of CompileOptions is debugger related metadata, destined for the ScriptSourceObject that is currently injected via CompileOptions.

We can remove this responsibility from CompileOptions by making it a post-processing step applied after script compilation. This has the knock on benefit of highlighting the places it is relevant or not relevant.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1702278 - Make CompileOptions a member of JSExecutionContext r?tcampbell

This simplified the use of JSExecutionContext, and make future patches
in this stack simpler.

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1702278 - Assert initialization of ScriptSourceObject r?tcampbell

This is a diagnostic patch to help catch misuse of the two phase initialization
of ScriptSourceObject. One potential enhancement would be to make this
modification debug only.

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1702278 - Move ScriptSourceObject::initFromOptions further out in compilation APIs r?tcampbell

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1702278 - Defer setting debug metadata until after script compilation is finished. r?tcampbell!,smaug!

Depends on D107566

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8fe8b5be92f
Make CompileOptions a member of JSExecutionContext r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/a52287ecc8ac
Assert initialization of ScriptSourceObject r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/3afa2b70c0f9
Defer setting debug metadata until after script compilation is finished. r=tcampbell,smaug

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e8fe8b5be92f
https://hg.mozilla.org/mozilla-central/rev/a52287ecc8ac
https://hg.mozilla.org/mozilla-central/rev/3afa2b70c0f9