1702329 - tab_line is too thin in Proton using a 3rd party theme

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P2)

Description

[Seburo]

In Photon, the tab-line element is 2px, but the new tab_line element in Proton is thinner, making the line harder to see in custom themes from AMO (see attached examples).

Comment 1

[Seburo]

Attachment: mozfest prod.png

Comment 2

[Seburo]

Attachment: mozfest proton.png

Comment 3

[Seburo]

For further background:

The aim of this bug is to reduce friction in the move to MR1 with equivalent visual elements in themes being of the same use. This will benefit users in the move to MR1 as well as theme artists who have made themes available through AMO that use this element as a feature of their theme to highlight the active tab.

At present, the tab_line element is not as visible in MR1, with the line appearing thinner and possibly also not picking up the colour specified in the tab_line field in the manifest.json for the theme.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1702329 - The outline should be applied using the spread-radius, with blur-radius set to 0.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6092057c08d
The outline should be applied using the spread-radius, with blur-radius set to 0. r=desktop-theme-reviewers,harry

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a6092057c08d

Comment 7

[Hani Yacoub, Desktop QA]

Verified as fixed on Windows 10 x64, macOS 10.15, Ubuntu 20.04 and on Windows 7 x64.