1702376 - Remove wipeAll support

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement, P3)

Description

[Mark Hammond [:markh] [:mhammond]]

We support a 'wipeAll' command, designed to wipe all engines from a client. This is not used in practice and I think this is misguided - a possible use-case might be for a lost device or similar, but in that scenario:

• A user probably would also expect non-sync data to be wiped
• A user would probably prefer to use features built into the OS so things other than Firefox are wiped.

We've carried the (unused) implementation into the rust components, so it often causes confusion (eg, "when is this called?" - the answer "never" is not obvious), and Lougenia just had to deal with it again for autofill.

So I propose we kill it. We can keep support for the plain "wipe" (which just targets a single collection) as that has at least 1 use-case (bookmarks), but the wipeAll footgun should go.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

This is, roughly, kill every reference in https://searchfox.org/mozilla-central/search?q=wipeAll without breaking anything else and ensuring all tests continue to pass.

Comment 2

[Ben Dean-Kawamura [:bdk]]

Attachment: Bug 1702376 - Removed the wipeAll command. r=markh

• Use wipeEngine("tabs") instead of wipeAll() as a test command in test_clients_engine.js
• Madet the engines param required in wipeRemote()

Comment 3

[Ben Dean-Kawamura [:bdk]]

I think this code is ready for review, what's the next step?

Comment 4

[Ben Dean-Kawamura [:bdk]]

Attachment: WIP: Bug 1702376: Updating sync engine logging

Ignore this one, I entered the wrong bug number.

Comment 5

[Phabricator Automation]

Comment on attachment 9218401 [details]
WIP: Bug 1702376: Updating sync engine logging

Revision D113385 was moved to bug 1552382. Setting attachment 9218401 [details] to obsolete.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a3e8c57d50f
Removed the wipeAll command.  r=markh

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7a3e8c57d50f