1702405 - WindowGlobalChild.cpp:399:20: error: ?MakeScopeExit? was not declared in this scope; did you mean ?scopeExit??

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Petr Sumbera]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:87.0) Gecko/20100101 Firefox/87.0

Steps to reproduce:

Solaris build fails with:

 7:32.39 In file included from Unified_cpp_dom_ipc2.cpp:56:
 7:32.39 /builds/psumbera/mozilla-central-build/dom/ipc/WindowGlobalChild.cpp: In member function ?mozilla::ipc::IPCResult mozilla::dom::WindowGlobalChild::RecvMakeFrameRemote(const mozilla::dom::MaybeDiscarded<mozilla::dom::BrowsingContext>&, mozilla::dom::PWindowGlobalChild::ManagedEndpoint<mozilla::dom::PBrowserBridgeChild>&&, const TabId&, const LayersId&, mozilla::dom::PWindowGlobalChild::MakeFrameRemoteResolver&&)?:
 7:32.39 /builds/psumbera/mozilla-central-build/dom/ipc/WindowGlobalChild.cpp:399:20: error: ?MakeScopeExit? was not declared in this scope; did you mean ?scopeExit??
 7:32.39   399 |   auto scopeExit = MakeScopeExit([&] { aResolve(true); });
 7:32.39       |                    ^~~~~~~~~~~~~
 7:32.39       |                    scopeExit

The first bad revision is:
changeset: 573913:e1fd1fa67a65
user: Nika Layzell <[e-mail]>
date: Wed Mar 31 16:51:58 2021 +0000
description:
Bug 1699721 - Part 2: Track BrowserParent lifecycles during process switches, r=kmag

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Navigation' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Petr Sumbera]

Attachment: Bug 1702405 - Add missing #include for MakeScopeExit.

Comment 3

[Dan Horák]

Petr, there seems to be more of these

 5:40.34 In file included from Unified_cpp_mediasniffer0.cpp:2:
 5:40.35 /mnt/dan/firefox.git/toolkit/components/mediasniffer/nsMediaSniffer.cpp: In member function ‘virtual nsresult nsMediaSniffer::GetMIMETypeFromContent(nsIRequest*, const uint8_t*, uint32_t, nsACString&)’:
 5:40.35 /mnt/dan/firefox.git/toolkit/components/mediasniffer/nsMediaSniffer.cpp:170:31: error: ‘MakeScopeExit’ is not a member of ‘mozilla’
 5:40.35   170 |   auto maybeUpdate = mozilla::MakeScopeExit([&channel]() {
 5:40.35       |                               ^~~~~~~~~~~~~
 5:41.00 gmake[4]: *** [/mnt/dan/firefox.git/config/rules.mk:676: Unified_cpp_mediasniffer0.o] Chyba 1

after fixing dom/ipc/WindowGlobalChild.cpp

Comment 4

[Petr Sumbera]

(In reply to Dan Horák from comment #3)

Petr, there seems to be more of these

 5:40.34 In file included from Unified_cpp_mediasniffer0.cpp:2:
 5:40.35 /mnt/dan/firefox.git/toolkit/components/mediasniffer/nsMediaSniffer.cpp: In member function ‘virtual nsresult nsMediaSniffer::GetMIMETypeFromContent(nsIRequest*, const uint8_t*, uint32_t, nsACString&)’:
 5:40.35 /mnt/dan/firefox.git/toolkit/components/mediasniffer/nsMediaSniffer.cpp:170:31: error: ‘MakeScopeExit’ is not a member of ‘mozilla’
 5:40.35   170 |   auto maybeUpdate = mozilla::MakeScopeExit([&channel]() {
 5:40.35       |                               ^~~~~~~~~~~~~
 5:41.00 gmake[4]: *** [/mnt/dan/firefox.git/config/rules.mk:676: Unified_cpp_mediasniffer0.o] Chyba 1

after fixing dom/ipc/WindowGlobalChild.cpp

This is older issue - Bug 1701154.

Comment 5

[Dan Horák]

aha, thanks :-)

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1699721

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86015112dd62
Add missing #include for MakeScopeExit. r=kmag

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/86015112dd62