Closed Bug 1702452 Opened 3 years ago Closed 3 years ago

Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_tabSwitchPrintPreview.js

Categories

(Firefox :: General, task, P5)

task

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: prathiksha, Assigned: rashadmad, Mentored)

Details

Attachments

(1 file)

This is a good first bug for newcomers to Firefox development.

BrowserTestUtils.waitForCondition in browser_tabSwitchPrintPreview.js[0] can be replaced with TestUtils.waitForCondition.

You can run this test with the ./mach test command:
./mach test browser/base/content/test/tabs/browser_tabSwitchPrintPreview.js

Feel free to get in touch with me on Matrix if you're stuck.

[0] https://searchfox.org/mozilla-central/rev/4fa18c26fa907f38d56b599571b9846af1506f3c/browser/base/content/test/tabs/browser_tabSwitchPrintPreview.js

Hello I am Rashad I would love this to be assigned to me as my first bug.

Assignee: nobody → rashadmad
Status: NEW → ASSIGNED

I was wondering where is the changeset ID located? I need it to push my changes to mozphab.

never mind about the changeset question, I pushed up a change to phabricator hopefully all is well if not just let me know: https://bugzilla.mozilla.org/show_bug.cgi?id=1702452 if everything is alright is it possible for me to be assigned another ticket? I dont know if you take weekends off.

Attachment #9213260 - Attachment description: Bug 1702452 - Replace BrowserTestUtils with TestUtils. r=prathiksha → Bug 1702452 - Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_tabSwitchPrintPreview.js. r=prathiksha
Pushed by prathikshaprasadsuman@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ed3c488e92c8
Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_tabSwitchPrintPreview.js. r=prathiksha
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: