1702516 - Remove the Temporarily Disable Extension button in the slow script notification

Status: VERIFIED FIXED

(Core :: XPConnect, enhancement)

Description

[Alex Thayer [:alexical] (she/her)]

This has not functioned properly for a long time, and no one seemed to complain. In order to reduce complexity, both for users and our code, let's just remove it.

Comment 1

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1702516 - Remove Temporarily disable extension button r?florian

Fairly straightforward - this removes the button from the slow add-on script
notification, as well as the functions that only it utilizes.

Comment 2

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1702516 - Remove all terminateGlobal uses r?smaug

This never actually worked, because nothing ever listened to the notification
sent in XPCJSContext (kill-content-script-sandbox). We're also removing the
"Temporarily disable extension" button in the slow addon notification, which
was the primary caller of this - however, that's in a separate patch.

Depends on D110582

Comment 3

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1702516 - Fix hang notification tests to not expect terminateGlobal r?florian

Depends on D110583

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebefc727472f
Remove Temporarily disable extension button r=florian
https://hg.mozilla.org/integration/autoland/rev/fc396e06eb5f
Remove all terminateGlobal uses r=kmag
https://hg.mozilla.org/integration/autoland/rev/357ba6ec00e6
Fix hang notification tests to not expect terminateGlobal r=florian

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ebefc727472f
https://hg.mozilla.org/mozilla-central/rev/fc396e06eb5f
https://hg.mozilla.org/mozilla-central/rev/357ba6ec00e6

Comment 6

[Peter Magyari (Desktop QA)]

Verified the fix using Nightly 89.0a1 (20210411210108) on MacOS 11, Windows 10 and Ubuntu 20.04.