Remove the Temporarily Disable Extension button in the slow script notification
Categories
(Core :: XPConnect, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | verified |
People
(Reporter: dthayer, Assigned: dthayer)
References
Details
(Whiteboard: [proton-infobars])
Attachments
(3 files)
This has not functioned properly for a long time, and no one seemed to complain. In order to reduce complexity, both for users and our code, let's just remove it.
|
Assignee | |
Comment 1•2 years ago
|
||
Fairly straightforward - this removes the button from the slow add-on script
notification, as well as the functions that only it utilizes.
|
|
Assignee | |
Comment 2•2 years ago
|
||
This never actually worked, because nothing ever listened to the notification
sent in XPCJSContext (kill-content-script-sandbox). We're also removing the
"Temporarily disable extension" button in the slow addon notification, which
was the primary caller of this - however, that's in a separate patch.
Depends on D110582
|
|
Assignee | |
Comment 3•2 years ago
|
||
Depends on D110583
Pushed by dothayer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ebefc727472f Remove Temporarily disable extension button r=florian https://hg.mozilla.org/integration/autoland/rev/fc396e06eb5f Remove all terminateGlobal uses r=kmag https://hg.mozilla.org/integration/autoland/rev/357ba6ec00e6 Fix hang notification tests to not expect terminateGlobal r=florian
|
||
Updated•2 years ago
|
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ebefc727472f
https://hg.mozilla.org/mozilla-central/rev/fc396e06eb5f
https://hg.mozilla.org/mozilla-central/rev/357ba6ec00e6
Verified the fix using Nightly 89.0a1 (20210411210108) on MacOS 11, Windows 10 and Ubuntu 20.04.
Description
•