Closed Bug 1702516 Opened 8 months ago Closed 8 months ago

Remove the Temporarily Disable Extension button in the slow script notification

Categories

(Core :: XPConnect, enhancement)

enhancement

Tracking

()

VERIFIED FIXED
89 Branch
Tracking Status
firefox89 --- verified

People

(Reporter: dthayer, Assigned: dthayer)

References

Details

(Whiteboard: [proton-infobars])

Attachments

(3 files)

This has not functioned properly for a long time, and no one seemed to complain. In order to reduce complexity, both for users and our code, let's just remove it.

Whiteboard: [proton-infobars]

Fairly straightforward - this removes the button from the slow add-on script
notification, as well as the functions that only it utilizes.

This never actually worked, because nothing ever listened to the notification
sent in XPCJSContext (kill-content-script-sandbox). We're also removing the
"Temporarily disable extension" button in the slow addon notification, which
was the primary caller of this - however, that's in a separate patch.

Depends on D110582

Pushed by dothayer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ebefc727472f
Remove Temporarily disable extension button r=florian
https://hg.mozilla.org/integration/autoland/rev/fc396e06eb5f
Remove all terminateGlobal uses r=kmag
https://hg.mozilla.org/integration/autoland/rev/357ba6ec00e6
Fix hang notification tests to not expect terminateGlobal r=florian
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

Verified the fix using Nightly 89.0a1 (20210411210108) on MacOS 11, Windows 10 and Ubuntu 20.04.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.