Closed Bug 1702582 Opened 2 years ago Closed 1 year ago

Partial OpenPGP encryption reminder not shown for inline messages that are decoded during retries

Categories

(MailNews Core :: Security: OpenPGP, defect)

defect

Tracking

(thunderbird_esr78+ fixed, thunderbird89+ fixed)

RESOLVED FIXED
90 Branch
Tracking Status
thunderbird_esr78 + fixed
thunderbird89 + fixed

People

(Reporter: KaiE, Assigned: KaiE)

References

(Regression)

Details

Attachments

(1 file)

Since bug 1672851, the "partial openpgp message" reminder is shown, only, if a decrypted (or signed decoded) message is seen in function notifyMessageDecryptDone.

Unfortunately, we have a timing problem, which was also noticed in bug 1681887.

For certain messages, depending on encodings, the openpgp processing will go async. It will retry, and for some retries, it opens a stream and a listener. (We haven't yet implemented a way to reliable notify us when all processing is done.)

As a consequence, the check done in notifyMessageDecryptDone, which checks that Enigmail.msg.decryptedMessage is set, might run at a time when it's not yet done...

I think for the purpose of showing the "partial" reminder, we don't need to have the final result yet. It's OK to show that reminder, whenever we learn that the original message is partial.

I understand the original motivation behind this check. In some scenarios, when processing fails, we might not reduce the message display to the subset. However, I intend to change that very soon as part of another issue. We can land those changes together with this one (I'll track that).

Pushed by kaie@kuix.de:
https://hg.mozilla.org/comm-central/rev/344d6a52a2de
Show partial OpenPGP message reminder for failed processing. r=aleca

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Comment on attachment 9213851 [details]
Bug 1702582 - Show partial OpenPGP message reminder for failed processing. r=aleca

[Approval Request Comment]
Regression caused by (bug #): 1702582
User impact if declined: confusing UI
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): low

Attachment #9213851 - Flags: approval-comm-beta?

Comment on attachment 9213851 [details]
Bug 1702582 - Show partial OpenPGP message reminder for failed processing. r=aleca

See above beta approval request for details.

Requesting esr78 approval, however, should wait for at least 2 weeks beta testing.

Attachment #9213851 - Flags: approval-comm-esr78?

Comment on attachment 9213851 [details]
Bug 1702582 - Show partial OpenPGP message reminder for failed processing. r=aleca

[Triage Comment]
Approved for beta

Attachment #9213851 - Flags: approval-comm-beta? → approval-comm-beta+

Comment on attachment 9213851 [details]
Bug 1702582 - Show partial OpenPGP message reminder for failed processing. r=aleca

[Triage Comment]
Approved for esr78

Attachment #9213851 - Flags: approval-comm-esr78? → approval-comm-esr78+
You need to log in before you can comment on or make changes to this bug.