1702582 - Partial OpenPGP encryption reminder not shown for inline messages that are decoded during retries

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Kai Engert [:KaiE:]]

Since bug 1672851, the "partial openpgp message" reminder is shown, only, if a decrypted (or signed decoded) message is seen in function notifyMessageDecryptDone.

Unfortunately, we have a timing problem, which was also noticed in bug 1681887.

For certain messages, depending on encodings, the openpgp processing will go async. It will retry, and for some retries, it opens a stream and a listener. (We haven't yet implemented a way to reliable notify us when all processing is done.)

As a consequence, the check done in notifyMessageDecryptDone, which checks that Enigmail.msg.decryptedMessage is set, might run at a time when it's not yet done...

I think for the purpose of showing the "partial" reminder, we don't need to have the final result yet. It's OK to show that reminder, whenever we learn that the original message is partial.

I understand the original motivation behind this check. In some scenarios, when processing fails, we might not reduce the message display to the subset. However, I intend to change that very soon as part of another issue. We can land those changes together with this one (I'll track that).

Comment 1

[Kai Engert [:KaiE:]]

Attachment: Bug 1702582 - Show partial OpenPGP message reminder for failed processing. r=aleca

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/344d6a52a2de
Show partial OpenPGP message reminder for failed processing. r=aleca

Comment 3

[Kai Engert [:KaiE:]]

Comment on attachment 9213851 [details]
Bug 1702582 - Show partial OpenPGP message reminder for failed processing. r=aleca

[Approval Request Comment]
Regression caused by (bug #): 1702582
User impact if declined: confusing UI
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Kai Engert [:KaiE:]]

Comment on attachment 9213851 [details]
Bug 1702582 - Show partial OpenPGP message reminder for failed processing. r=aleca

See above beta approval request for details.

Requesting esr78 approval, however, should wait for at least 2 weeks beta testing.

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9213851 [details]
Bug 1702582 - Show partial OpenPGP message reminder for failed processing. r=aleca

[Triage Comment]
Approved for beta

Comment 6

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/releases/comm-beta/rev/4fde35101fdf8d0ae0a76b38908a8bed2a9b9ec6
89.0b3

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9213851 [details]
Bug 1702582 - Show partial OpenPGP message reminder for failed processing. r=aleca

[Triage Comment]
Approved for esr78

Comment 8

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/releases/comm-esr78/rev/331ebb729fc6770c1ffed7202cbbed73f6eba990
78.10.2