Closed Bug 1702603 Opened 8 months ago Closed 8 months ago

Enter/Space does not work on buttons inside proton infobars

Categories

(Firefox :: Keyboard Navigation, defect, P1)

Unspecified
All
defect

Tracking

()

VERIFIED FIXED
89 Branch
Tracking Status
firefox87 --- unaffected
firefox88 --- unaffected
firefox89 --- verified

People

(Reporter: peter.magyari, Assigned: enndeakin)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proton-infobars])

Attachments

(1 file)

Affected versions
Fx 89.0a1

Affected platforms
Windows 10
Ubuntu 20.04
MacOS 11

Preconditions
Make sure to set the following prefs to "true":
browser.proton.enabled
browser.proton.infobars.enabled

Steps to reproduce

  1. Launch Firefox
  2. Navigate to https://permission.site/
  3. Click on "Protocol Handler" inside the page
  4. Navigate to the "Protocol Handler" infobar using "TAB"
  5. When you are on the "Add application" button press "Enter/Space" to use it

Expected result
The button is pressed and the infobar is dismissed

Actual result
The button is not actionable via keyboard

Notes
This behaviour is noticeable on other infobars as well
The "Enter/Space" buttons work on the "X" close button and "Learn More" links (where applicable)

Assignee: nobody → enndeakin
Status: NEW → ASSIGNED

This appears to be an a11y issue, I'm not sure if Asa has seen this to set an a11y priority on this, but I'm setting this as P2A.

Flags: needinfo?(asa)
Priority: -- → P2
Whiteboard: [proton-infobars] → [proton-infobars] [priority:2a]

Bumping to P1 after discussion on this morning's triage call as we believe this breaks usage for people with screen readers.

Priority: P2 → P1
Whiteboard: [proton-infobars] [priority:2a] → [proton-infobars]
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ae4aeeddd795
use command event for buttons in notificationbar, r=mstriemer

Backed out for causing browser-chrome failures in browser_Heartbeat.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/d64c1382f146846d7c1a1f399f195e3b9c5010d7

Push with failures

Failure log

Flags: needinfo?(enndeakin)
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/89a6a6b7c07e
use command event for buttons in notificationbar, r=mstriemer
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Flags: needinfo?(enndeakin)

Verified the fix using Nightly 89.0a1 (20210413214314) on Windows 10, MacOS 11 and Ubuntu 20.04

Status: RESOLVED → VERIFIED
Flags: needinfo?(asa)
You need to log in before you can comment on or make changes to this bug.