1702603 - Enter/Space does not work on buttons inside proton infobars

Status: VERIFIED FIXED

(Firefox :: Keyboard Navigation, defect, P1)

Description

[Peter Magyari (Desktop QA)]

Affected versions
Fx 89.0a1

Affected platforms
Windows 10
Ubuntu 20.04
MacOS 11

Preconditions
Make sure to set the following prefs to "true":
browser.proton.enabled
browser.proton.infobars.enabled

Steps to reproduce

1. Launch Firefox
2. Navigate to https://permission.site/
3. Click on "Protocol Handler" inside the page
4. Navigate to the "Protocol Handler" infobar using "TAB"
5. When you are on the "Add application" button press "Enter/Space" to use it

Expected result
The button is pressed and the infobar is dismissed

Actual result
The button is not actionable via keyboard

Notes
This behaviour is noticeable on other infobars as well
The "Enter/Space" buttons work on the "X" close button and "Learn More" links (where applicable)

Comment 1

[Neil Deakin]

Attachment: Bug 1702603, use command event for buttons in notificationbar, r=mstriemer

Comment 2

[Tyler Duzan]

This appears to be an a11y issue, I'm not sure if Asa has seen this to set an a11y priority on this, but I'm setting this as P2A.

Comment 3

[Tyler Duzan]

Bumping to P1 after discussion on this morning's triage call as we believe this breaks usage for people with screen readers.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae4aeeddd795
use command event for buttons in notificationbar, r=mstriemer

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing browser-chrome failures in browser_Heartbeat.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/d64c1382f146846d7c1a1f399f195e3b9c5010d7

Push with failures

Failure log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89a6a6b7c07e
use command event for buttons in notificationbar, r=mstriemer

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/89a6a6b7c07e

Comment 8

[Peter Magyari (Desktop QA)]

Verified the fix using Nightly 89.0a1 (20210413214314) on Windows 10, MacOS 11 and Ubuntu 20.04