1702637 - BrowserTestUtils.switchTab should not wait for an implied timer from AsyncTabSwitcher

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[Florian Quèze [:florian]]

BrowserTestUtils.switchTab waits for the TabSwitchDone event from AsyncTabSwitcher, but that event happens after a 300ms timer.

On debug builds that doesn't change the timing much, but on optimized builds, that makes the tests run significantly slower than they need to.

I'm going to attach a WIP patch, but if we want to go ahead with it I'll have lots of tests to debug, as my try run is currently pretty orange: https://treeherder.mozilla.org/jobs?repo=try&revision=d44cba986ec22d6e32218c2fd5573bda5151bad0

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1702637 - AsyncTabSwitcher should send the TabSwitchDone event as soon as the new selected tab has been painted, r=mconley.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 3

[Suhaib Mujahid [:suhaib]]

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.

Comment 4

[Florian Quèze [:florian]]

Resetting the assignee as I'm not actively working on this. But I still think this is worth fixing!

Comment 5

[Florian Quèze [:florian]]

Attachment: Bug 1702637 - make BrowserTestUtils.switchTab wait for TabSwitched instead of TabSwitchDone, r=Gijs.

Comment 6

[Florian Quèze [:florian]]

Attachment: Bug 1702637 - set the test.wait300msAfterTabSwitch pref to true in tests that failed on try, r=Gijs,jmaher.

Comment 7

[Florian Quèze [:florian]]

Attachment: Bug 1702637 - set the test.wait300msAfterTabSwitch pref to true in chrome mochitests that failed on try, r=Gijs.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e548bf7e11b0
https://hg.mozilla.org/integration/autoland/rev/83d172a8677f
make BrowserTestUtils.switchTab wait for TabSwitched instead of TabSwitchDone, r=extension-reviewers,credential-management-reviewers,search-reviewers,fxview-reviewers,tabbrowser-reviewers,places-reviewers,urlbar-reviewers,profiles-reviewers,scunnane,jteow,robwu,mossop,dao,dimi.
https://github.com/mozilla-firefox/firefox/commit/9786bbf2abd4
https://hg.mozilla.org/integration/autoland/rev/7406ff85a2b4
set the test.wait300msAfterTabSwitch pref to true in tests that failed on try, r=jmaher,necko-reviewers,webcompat-reviewers,extension-reviewers,media-playback-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,fxview-reviewers,anti-tracking-reviewers,sessionstore-reviewers,tabbrowser-reviewers,places-reviewers,dom-storage-reviewers,translations-reviewers,home-newtab-reviewers,urlbar-reviewers,firefox-ai-ml-reviewers,profiles-reviewers,alwu,janv,twisniewski,scunnane,kershaw,robwu,dimi,mconley,nsharpley,jteow,mossop.
https://github.com/mozilla-firefox/firefox/commit/9bfafd9fcf51
https://hg.mozilla.org/integration/autoland/rev/8ac3e54795a2
set the test.wait300msAfterTabSwitch pref to true in chrome mochitests that failed on try, r=Gijs,extension-reviewers,robwu.

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/83d172a8677f
https://hg.mozilla.org/mozilla-central/rev/7406ff85a2b4
https://hg.mozilla.org/mozilla-central/rev/8ac3e54795a2