Closed Bug 1702708 Opened 6 months ago Closed 2 months ago

hyphenate the places context menu attributes

Categories

(Firefox :: Bookmarks & History, task, P5)

task

Tracking

()

RESOLVED FIXED
92 Branch
Tracking Status
firefox92 --- fixed

People

(Reporter: mak, Assigned: nootsponge, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(2 files, 1 obsolete file)

we have a bunch of attributes in placesContextMenu.inc.xhtml that are used in places/content/controller.js with long names like hideifnodetype, hideifprivate and so on. It would be nice to hyphenate most of these so they become hide-if-node-type, ...

One can run the browser_bookmark_context_menu_contents.js mochitest to check for mistakes.

This is a good first bug to make experience in the Firefox code base.

Hi, I'm with the outreachy program.
Can I work on this bug?

Sure, feel free to start working on a patch and once you attach it I'll assign the bug to you. That way you can start checking your environment is sane and working to build and run tests.
I'm available for questions, just ask.

Assignee: nobody → filipa.sr2
Status: NEW → ASSIGNED

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Assignee: filipa.sr2 → nobody
Status: ASSIGNED → NEW

Seems relatively simple, and it looks like the last bug that was blocking this bug has been closed. Are there any new blocks that I should know about?

Also, I've just been fooling around with this and I'm not quite sure but I ran the mochitest and it came back with quite a few failures, which I assume would be relatively normal, but is there an easier way to test or filter just the sections I'm working on?

Thanks.

Flags: needinfo?(mak)

(In reply to Nicholas F. [:nootsponge] (he/him) from comment #6)

Seems relatively simple, and it looks like the last bug that was blocking this bug has been closed. Are there any new blocks that I should know about?

No, it should be good to go.

Also, I've just been fooling around with this and I'm not quite sure but I ran the mochitest and it came back with quite a few failures, which I assume would be relatively normal, but is there an easier way to test or filter just the sections I'm working on?

You can ./mach mochitest /path_to_relevant_tests... I think for this area you could just run tests in browser/components/places

Flags: needinfo?(mak)

(In reply to Marco Bonardo [:mak] from comment #7)

(In reply to Nicholas F. [:nootsponge] (he/him) from comment #6)

Seems relatively simple, and it looks like the last bug that was blocking this bug has been closed. Are there any new blocks that I should know about?

No, it should be good to go.

Also, I've just been fooling around with this and I'm not quite sure but I ran the mochitest and it came back with quite a few failures, which I assume would be relatively normal, but is there an easier way to test or filter just the sections I'm working on?

You can ./mach mochitest /path_to_relevant_tests... I think for this area you could just run tests in browser/components/places

Yeah, sorry, was just about to reply. I think I accidentally interrupted on the first couple of tries and it failed but I ran it some more and it looks like it's running perfectly fine now.

I'll post a diff soon, thanks for the quick reply!

Assignee: nobody → andrew
Status: NEW → ASSIGNED
Attachment #9213391 - Attachment is obsolete: true
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/319dc5ec8d89
Hyphenate places context menu attributes r=mak
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.