1702708 - hyphenate the places context menu attributes

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, task, P5)

Description

[Marco Bonardo [:mak]]

we have a bunch of attributes in placesContextMenu.inc.xhtml that are used in places/content/controller.js with long names like hideifnodetype, hideifprivate and so on. It would be nice to hyphenate most of these so they become hide-if-node-type, ...

One can run the browser_bookmark_context_menu_contents.js mochitest to check for mistakes.

This is a good first bug to make experience in the Firefox code base.

Comment 1

[Filipa Rocha]

Hi, I'm with the outreachy program.
Can I work on this bug?

Comment 2

[Marco Bonardo [:mak]]

Sure, feel free to start working on a patch and once you attach it I'll assign the bug to you. That way you can start checking your environment is sane and working to build and run tests.
I'm available for questions, just ask.

Comment 3

[Filipa Rocha]

Attachment: Bug 1702708 hyphenated attributes names. r=mak

Comment 4

[Filipa Rocha]

Attachment: Bug 1702708 hyphenated attributes names. r=mak

Comment 5

[Release mgmt bot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 6

[Nicholas F. [:nootsponge] (he/him)]

Seems relatively simple, and it looks like the last bug that was blocking this bug has been closed. Are there any new blocks that I should know about?

Also, I've just been fooling around with this and I'm not quite sure but I ran the mochitest and it came back with quite a few failures, which I assume would be relatively normal, but is there an easier way to test or filter just the sections I'm working on?

Thanks.

Comment 7

[Marco Bonardo [:mak]]

(In reply to Nicholas F. [:nootsponge] (he/him) from comment #6)

Seems relatively simple, and it looks like the last bug that was blocking this bug has been closed. Are there any new blocks that I should know about?

No, it should be good to go.

Also, I've just been fooling around with this and I'm not quite sure but I ran the mochitest and it came back with quite a few failures, which I assume would be relatively normal, but is there an easier way to test or filter just the sections I'm working on?

You can ./mach mochitest /path_to_relevant_tests... I think for this area you could just run tests in browser/components/places

Comment 8

[Nicholas F. [:nootsponge] (he/him)]

(In reply to Marco Bonardo [:mak] from comment #7)

(In reply to Nicholas F. [:nootsponge] (he/him) from comment #6)

Seems relatively simple, and it looks like the last bug that was blocking this bug has been closed. Are there any new blocks that I should know about?

No, it should be good to go.

Also, I've just been fooling around with this and I'm not quite sure but I ran the mochitest and it came back with quite a few failures, which I assume would be relatively normal, but is there an easier way to test or filter just the sections I'm working on?

You can ./mach mochitest /path_to_relevant_tests... I think for this area you could just run tests in browser/components/places

Yeah, sorry, was just about to reply. I think I accidentally interrupted on the first couple of tries and it failed but I ran it some more and it looks like it's running perfectly fine now.

I'll post a diff soon, thanks for the quick reply!

Comment 9

[Nicholas F. [:nootsponge] (he/him)]

Attachment: Bug 1702708 - Hyphenate places context menu attributes r?mak

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/319dc5ec8d89
Hyphenate places context menu attributes r=mak

Comment 11

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/319dc5ec8d89