1702810 - double shadow on the bookmarks menu popup

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect, P2)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

If you add the bookmarks button to the toolbar, there's a second border and a shadow around the bookmarks button menupopup.

I quickly made up a few change to solve this, but didn't test it deeply:

diff --git a/browser/themes/windows/customizableui/panelUI.css b/browser/themes/windows/customizableui/panelUI.css
--- a/browser/themes/windows/customizableui/panelUI.css
+++ b/browser/themes/windows/customizableui/panelUI.css
@@ -19,16 +19,21 @@
 @supports -moz-bool-pref("browser.proton.contextmenus.enabled") {
 @media (-moz-windows-default-theme) and (-moz-os-version: windows-win10) {
   /* Prevent the global arrowscrollbox rules from replacing our background,
      or adding more padding that would misalign our submenus. */
   #BMB_bookmarksPopup::part(arrowscrollbox),
   #BMB_bookmarksPopup menupopup[placespopup=true]::part(arrowscrollbox) {
     background-color: var(--arrowpanel-background);
     padding-block-start: 0;
+    border: none;
+  }
+
+  #BMB_bookmarksPopup {
+    -moz-window-shadow: none;
   }
 }
 }

 #BMB_bookmarksPopup menupopup[placespopup=true]::part(innerbox) {
   /* emulating MozPlacesPopupArrow but without the arrow */
   box-shadow: 0 0 4px rgba(0,0,0,0.2);
   background: var(--arrowpanel-background);

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(the second rule should probably be moved out of contextmenus, it was just a quick hack)

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1700148

Comment 3

[Mike Conley (:mconley) (:⚙️)]

ni'ing Neil, since this looks like fallout from bug 1700148.

Comment 4

[Neil Deakin]

The fix mentioned above will remove the dropshadow. The only other change made by bug 1700148 was to add a border-radius.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Thanks, Neil. mak, do you have time to post your patch for review?

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I... think so.

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: Bug 1702810 - Remove double shadow from the bookmarks menu panel. r=mconley

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/206a10c2fae7
Remove double shadow from the bookmarks menu panel. r=NeilDeakin

Comment 9

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/206a10c2fae7