1702899 - White-on-white text in <input type="date"> popup in Dark Mode, if widget.macos.respect-system-appearance is true

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P2)

Description

[Markus Stange [:mstange]]

Steps to reproduce:

1. Set widget.macos.respect-system-appearance to true.
2. Set the system theme or the Firefox theme to dark.
3. Load data:text/html,<input type="date">
4. Click in the text field to open the date panel.

Expected results:
The contents should be readable.

Actual results:
White-on-white unreadable text

Comment 1

[Markus Stange [:mstange]]

Attachment: screenshot

Comment 2

[Harry Twyford]

Attachment: Bug 1702899 - Support dark datetime pickers on macOS. r?#desktop-theme-reviewers!,ntim

This patch also removes the --default-arrowpanel-* variables. The only place they were used (ever?) was the datetime picker. Tim, I'm not sure of your level of involvement these days, but I'd be grateful if you could take a look seeing as you're both a themes expert and a Mac user.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ffdff1b7e43
Support dark datetime pickers on macOS. r=desktop-theme-reviewers,dao

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3ffdff1b7e43

Comment 6

[Timea Zsoldos [:tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 89.0a1 (2021.04.03) on macOs 11, dark mode ( widget.macos.respect-system-appearance = true) .
I can confirm this issue is fixed, I verified using Firefox 91.0a1 and 90.0b4 on macOS 11.