Closed Bug 1702945 Opened 4 years ago Closed 2 years ago

Bookmarks toolbar menu button submenus are missing rounded corners and parts of the shadow in Proton

Categories

(Firefox :: Menus, defect, P2)

Desktop
Windows 10
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox89 --- affected

People

(Reporter: asa, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-door-hangers] [priority:2b])

Attachments

(1 file)

Sub-menus aren't styled properly in Proton. They have square corners and don't have the correct drop shadow. I'm on today's nightly, I've enabled the proton main pref and the proton doorhangers pref and this is what I see

The screenshot is from Win10, I haven't tried to reproduce there or elsewhere, but setting bug info for now.

Worth noting that the bookmarks toolbar menu button is Very Special, implementation-wise, and there isn't a straightforward way of testing UI styling, which is why we keep breaking subtle parts of it. :-(

Severity: -- → S4
OS: Unspecified → Windows 10
Hardware: Unspecified → Desktop
Summary: sub-menus are not styled properly in Proton → Bookmarks toolbar menu button submenus are missing rounded corners and parts of the shadow in Proton
Whiteboard: [proton-door-hangers]
Priority: -- → P2
Whiteboard: [proton-door-hangers] → [proton-door-hangers] [priority:2b]
See Also: → 1701637

The severity field for this bug is set to S4. However, the following bug duplicate has higher severity:

:jaws, could you consider increasing the severity of this bug to S3?

For more information, please visit auto_nag documentation.

Flags: needinfo?(jaws)

This should have been fixed by work done in another big.
Asa, can you confirm everything looks OK?

Flags: needinfo?(asa)
Flags: needinfo?(jaws)

Confirmed with Asa that the drop shadows look as expected now and the submenu radius is applied correctly.

Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(asa)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: