1702999 - Folder icons appear late in the Bookmarks Panel folder selector

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

1. Click on the Bookmarks button in the URL bar
2. Click on the expander next to the folder selector menulist
3. Click on the button to create a new folder (bottom of the tree selector)

ER:

The new entry in the tree should show a folder icon to the left of the text input.

AR:

The new entry in the tree only shows the text input, and the folder doesn't appear until the user completes filling in the text input.

Comment 1

[Tyler Duzan]

I noticed this when doing my PM review as well. I'm setting this as 2a because it was very obvious and a bit jarring, this is an item I'd like to see polished before we ship if we can.

Comment 2

[Oana Botisan, Desktop QA]

We managed to reproduce the issue on Windows 10 x64 and Ubuntu 18.04 x64.

MacOS 10.15 doesn't seem to be affected.

Comment 3

[Oana Botisan, Desktop QA]

Also, it seems that this issue is reproducing without Proton enabled. It reproduces on Firefox 87.0, too.

Comment 4

[Oana Botisan, Desktop QA]

Attachment: image.png

I found out that the issue is not reproducing while using a High Contrast theme. I just found out that while testing on Windows 7 x32.

Comment 5

[Bernard Igiri]

Attachment: Bug 1702999 - New folder icons not visible in Bookmarks Panel r=mconley,dao

Set the background of the new folder item to a value that properly contrasts with the color of the new folder icon.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8dd62880c934
New folder icons not visible in Bookmarks Panel r=mconley,dao

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8dd62880c934

Comment 8

[Romain Testard [:RT]]

Confirming here that we (UX and PM) want this uplifted for MR1 to Beta.

Comment 9

[Bernard Igiri]

Comment on attachment 9219959 [details]
Bug 1702999 - New folder icons not visible in Bookmarks Panel r=mconley,dao

Beta/Release Uplift Approval Request

• User impact if declined: MR1 / proton impact: Missing folder icon
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: - Click the star in the URL bar to add a bookmark.

• In the popup click the down arrow to right of the folder drop down.
• Click the New Folder button.
• Verify that the line to name the new folder also displays the folder icon to the left of the input field.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): CSS only.
• String changes made/needed:

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9219959 [details]
Bug 1702999 - New folder icons not visible in Bookmarks Panel r=mconley,dao

Low risk in early beta, approved for 89 beta 10, thanks.

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/de8716feaf71

Comment 12

[Oana Botisan, Desktop QA]

Verified the fix using latest Nightly 90.0a1 and Firefox 89.0b10 on Windows 10 x64, macOS 10.15 and Ubuntu 18.04 x64. The issue is not reproducing anymore.