17030 - Need to remove dead code from widget

Status: VERIFIED WONTFIX

(Core :: XUL, defect, P3)

Description

[Simon Fraser [no longer active]]

We need to somehow factor out the dead code from widget, or at least move it
someplace else. This is mostly native widget code.

Comment 1

[Mike Pinkerton (not reading bugmail)]

this can be post beta, imho.

Comment 2

[Peter Trudelle]

Pink says that about 135K of this is used in Viewer.  At what point does excess
bloat in mozilla trump the convenience of the Viewer test app?  We need to
either make all of this code conditional, move it into Viewer somehow, or cut
Viewer loose.
cc'ing rickg for input.

Comment 3

[Mike Pinkerton (not reading bugmail)]

cc'ing smfr, pierre, sdagely, beard, and trudelle.

viewer, as of about two months ago, does not work at all on macOS. It has totally
bitrotted. You can only view test0 since you can't type in the url field and i'm
unsure about it even being able to view network pages if we could type there. So
it's busted, no one is fixing it, no one cares, but we still ship it.

Not only that, but in order to keep the text widget in it working, we also have
to ship WasteLib in our release builds, which is 120K (yes!) of code that is not
used for anything in the mozill app, and doesn't even work in widget.

So what do we do?

Comment 4

[Peter Trudelle]

Mass moving M18 bugs to M19

Comment 5

[Peter Trudelle]

mass-moving all bugs to m21 that are not dogfood+ or nsbeta2+ or nsbeta2-

Comment 6

[Mike Pinkerton (not reading bugmail)]

someone needs to list what still remains for this bug...i forget.

Comment 7

[Pierre Saslawsky]

I guess we can remove the rest of the native widgets; that means removing them 
from the factory as well. It's only 50k of code but as you wrote, it would allow 
us to remove WasteLib too.
  nsMacControl
  nsLabel
  nsButton
  nsScrollbar
  nsTextWidget

Comment 8

[Mike Pinkerton (not reading bugmail)]

wasteLib has been gone for some time now. removing these widgets, however, would 
break viewer (which i don't care about but some do).

Comment 9

[Peter Trudelle]

->future

Comment 10

[Mike Pinkerton (not reading bugmail)]

size is of importance to embedding

Comment 11

[Mike Pinkerton (not reading bugmail)]

shouldn't we move away from viewer and use the embedding test harnesses? That
allows us to get rid of the dead code in widget that's only used for viewer.

Comment 12

[Mike Pinkerton (not reading bugmail)]

--> gecko

Comment 13

[dcone (gone)]

Viewer will always be important for testing.  There are regression test in 
viewer that printing and tables use.
Marking as wontfix because I am not sure what needs to be done here.  If somone 
can explain.. then this bug can go the the responsible person.  

Comment 14

[Chris Waterson]

Hey dcone, before we close this bug, I wonder if we could do a quick swag at 
measuring how much dead code there actually is? The linux linker does not 
dead-strip code like the windows linker does, so this will end up bloating the 
widget DLL. If it's 100 bytes, who cares, but if it's even 5 or 10KB, it could 
be worthwhile to fix this `right'.

Comment 15

[sairuh (rarely reading bugmail)]

mass-verifying WontFix bugs which haven't changed since 2001-12-31.

use the search string "BoletusEdulis" if you want to filter out this msg.