1703036 - Search mode chiclet has unreadable close button in High Contrast Mode

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Petruta Horea [:phorea]]

Attachment: high contrast close button

[Affected versions]:

• Firefox 88 beta 7
• latest Nightly 89.0a1 2021-04-04

[Affected platforms]:

• Win 10 64-bit

[Preconditions]:
Open Settings -> High Contrast app in Windows 10 and select one of the default themes: High Contrast #1, High Contrast #2 or High Contrast Black

[Steps to reproduce]:

1. Focus address bar and select a search shortcut to open search mode
2. Hover over the search mode chiclet in address bar

[Expected result]:

• [x] close button is visible in high contrast mode

[Actual result]:

• [x] close button is black

[Regression range]:

• This regressed in Firefox 88, will return with a regression range ASAP

[Additional notes]:

• This issue is not reproducible in High Contrast White default theme

Comment 1

[Pablo]

Mozregression:

build_url: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/LDgI8vzRRFCOZnPQ6X1UDQ/runs/0/artifacts/public%2Fbuild%2Ftarget.zip
changeset: 8e8d076438b488b70ec57167a62444f5e47778d5
pushlog_url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8e8d076438b488b70ec57167a62444f5e47778d5&tochange=0cbf8e24836a65cf2bee34ef13e88c96111665c1

Bug 1691531 - Part 2 - Update the Urlbar label box colors (Proton).

Comment 2

[Marco Bonardo [:mak]]

This is a non-proton regression caused by proton work.

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1703036 - Search mode chiclet has unreadable close button in High Contrast Mode. r=harry

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5468626655d
Search mode chiclet has unreadable close button in High Contrast Mode. r=harry,desktop-theme-reviewers

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f5468626655d

Comment 6

[Marco Bonardo [:mak]]

Comment on attachment 9214037 [details]
Bug 1703036 - Search mode chiclet has unreadable close button in High Contrast Mode. r=harry

Beta/Release Uplift Approval Request

• User impact if declined: The search mode chiclet close button is not visible in high contrast mode
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Test the search mode chiclet close button in high contrast mode when Proton is disabled
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple css change
• String changes made/needed:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9214037 [details]
Bug 1703036 - Search mode chiclet has unreadable close button in High Contrast Mode. r=harry

Approved for 88.0b9.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c6d9107d4c21

Comment 9

[Petruta Horea [:phorea]]

Verified in Firefox 88 beta 9 and latest Nightly 89.0a1 2021-04-12, under Win 10 64-bit.

Mak, could you please provide your input for the following cases?

• This issue reproduces now with High Contrast Black and Firefox Light theme. Since this is an unusual combination, should I file it as follow-up?
• With High Contrast Black and Firefox Dark theme, I notice that address bar panel highlights are grey (Proton like), as opposed to blue (default text selection in HCM). In this case, should the highlight follow OS's direction or browser's?

Thank you!

Comment 10

[Marco Bonardo [:mak]]

(In reply to Petruta Horea [:phorea] from comment #9)

• This issue reproduces now with High Contrast Black and Firefox Light theme. Since this is an unusual combination, should I file it as follow-up?

Yes, there is still a bug here, and I think it's due to missing a -moz-proton check around this rule https://searchfox.org/mozilla-central/rev/fa48ebee58d59fa846919c3e2c3122b08db57c9c/browser/themes/shared/urlbar-searchbar.inc.css#462-465
As you said this is a not so common case, so I don't think we'll fix it, considered it would require an uplift and would become pointless with the release of Proton. I'd prefer to concentrate on ensuring HC is right in Proton, since we handled the most common case here.
Thus I'd suggest to not file a bug and accept that bug exists.

• With High Contrast Black and Firefox Dark theme, I notice that address bar panel highlights are grey (Proton like), as opposed to blue (default text selection in HCM). In this case, should the highlight follow OS's direction or browser's?

I think High Contrast users should use the Default theme and if they really want to pick a theme, they'll hopefully pick an LWT theme that satisfies their need, rather than a broken one. LWT themes, like Dark, hardcode various colors and may not be a good choice for HC users, in general, but again it's their choice. I don't think that's a bug, the user requested that theme, and the theme may hardcode some colors by choice.

Comment 11

[Petruta Horea [:phorea]]

Thank you for detailed explanations!

Based on the above comments, I'm marking this as verified.