1703044 - Font colours in panels do not match Proton specifications

Status: VERIFIED FIXED

(Firefox :: Theme, task, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

Default / Light theme:
Primary text - color: #15141A;
Secondary text (for things like subheaders) - color: #5B5B66;

Dark theme:
Primary text - color: #FBFBFE;
Secondary text (for things like subheaders) - color: #BFBFC9;

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1703044 - Update the caclulation of the panel secondary text to get it closer to the UX spec.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ad29c902ff4
Update the caclulation of the panel secondary text to get it closer to the UX spec. r=desktop-theme-reviewers,dao

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out for causing bc failures on browser_ext_themes_arrowpanels.js.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=4ad29c902ff4720279babf3c0a5e0f4268031653&selectedTaskRun=TTYx066sRo-h16Q6hxZqwA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=337782690&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/4b2097f5a2369ceea04cb1b9f428600ec2501f23

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f713fc7d78a5
Update the caclulation of the panel secondary text to get it closer to the UX spec. r=desktop-theme-reviewers,dao

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f713fc7d78a5

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9217179 [details]
Bug 1703044 - Update the caclulation of the panel secondary text to get it closer to the UX spec.

Beta/Release Uplift Approval Request

• User impact if declined: Required for MR1/Proton
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Add the "Forget" button to the toolbar
  Click on the button
  Check the text color of the secondary and primary text in the window (ignoring the red text)
  Compare it to the colors in https://www.figma.com/file/0XjasINHogZOxcxSmYfs4i/Colours?node-id=26%3A265

Colors should be very close but might not be exact

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): CSS-only change
• String changes made/needed: none

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9217179 [details]
Bug 1703044 - Update the caclulation of the panel secondary text to get it closer to the UX spec.

Approved for 89 beta 6, thanks.

Comment 8

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/d34926e5078b

Comment 9

[Ciprian Georgiu, Desktop QA]

I have verified this fix using the steps from comment 6, on the latest builds: Nightly 90.0a1 and Beta 89.0b7. This was verified on Ubuntu 18.04 x64, Win 10 x64 and macOS 10.15.